Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert line height changes #530

Merged
merged 2 commits into from Jun 20, 2013
Merged

Revert line height changes #530

merged 2 commits into from Jun 20, 2013

Conversation

@eschweic
Copy link

eschweic commented Jun 20, 2013

This reverts 7dcff2b which broke line heights on lipsum.html
eschweic added 2 commits Jun 20, 2013
eschweic
Merge branch 'master' of https://github.com/mozilla/servo
0dad4d1
eschweic
Revert "Add initial support for the line-height property. Line height…
0bb3fbd 
… is only based on the tallest box in each line and does not factor in the vertical-alignment. Improves whitespace handling by passing the whitespace state between function invocations."

This reverts commit 7dcff2b, reversing
changes made to 93eea6b.
@pcwalton
Copy link
Contributor

pcwalton commented Jun 20, 2013

This has also caused Wikipedia to display images on top of other images.
pcwalton added a commit that referenced this pull request Jun 20, 2013
@pcwalton
Merge pull request #530 from eschweic/master
6301b18 
Revert line height changes
@pcwalton pcwalton merged commit 6301b18 into servo:master Jun 20, 2013
@pcwalton pcwalton mentioned this pull request Jun 20, 2013
Merged
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
@foolip
Merge pull request servo#530 from foolip/bomstrip
66f434f 
Remove UTF-8 BOMs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@eschweic @pcwalton
You can’t perform that action at this time.