Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing StorageEvent interface #5306

Merged
merged 2 commits into from Mar 24, 2015
Merged

Implementing StorageEvent interface #5306

merged 2 commits into from Mar 24, 2015

Conversation

@snf
Copy link
Contributor

snf commented Mar 21, 2015

Needed for #5196
@highfive
Copy link

highfive commented Mar 21, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 21, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4325

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@snf snf force-pushed the snf:storage_event branch from 67861af to ebd5e28 Mar 21, 2015
@snf
Copy link
Contributor Author

snf commented Mar 21, 2015

r? @Ms2ger
@jdm
Copy link
Member

jdm commented Mar 23, 2015

In future, please follow the instructions of @hoppipolla-critic-bot and avoid force pushing :)
@jdm
Copy link
Member

jdm commented Mar 23, 2015

Looks pretty good! Just a few changes necessary; I left comments on Critic.
@jdm
Copy link
Member

jdm commented Mar 23, 2015

Squash!
@snf snf force-pushed the snf:storage_event branch from 266e94d to 38f66d5 Mar 23, 2015
@jdm jdm added S-awaiting-merge and removed S-needs-squash labels Mar 23, 2015
bors-servo pushed a commit that referenced this pull request Mar 23, 2015
bors-servo
auto merge of #5306 : snf/servo/storage_event, r=jdm
Loading status checks…
a8fbd34 
Needed for #5196
@jdm
Copy link
Member

jdm commented Mar 24, 2015

Ye olde test-content is still failing:

thread '/home/servo/buildbot/slave/linux1/build/tests/content/test_interfaces.html' panicked at 'ALERT: TEST-UNEXPECTED-FAIL | StorageEvent is in [object Object]: If this is failing: DANGER, are you sure you want to expose the new interface StorageEvent to all webpages as a property on the window? Do not make a change to this file without review from jdm or Ms2ger for that specific change!', ../../tests/contenttest.rs:129

It just requires adding the StorageEvent interface to the list in test_interfaces.html.
@jdm jdm added S-tests-failed and removed S-awaiting-merge labels Mar 24, 2015
snf added 2 commits Mar 21, 2015
@snf
implementing StorageEvent interface
db6aeef
@snf
Update web-platform-tests expected data to revision 56db12eee9711048e…
Loading status checks…
89c208d 
…a4c927a89b9e9e05fd97c1b
@snf snf force-pushed the snf:storage_event branch from 4c5bd2c to 89c208d Mar 24, 2015
@snf
Copy link
Contributor Author

snf commented Mar 24, 2015

Updated the tests and checked they worked this time (and already squashed).
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on 89c208d Mar 24, 2015

r+
@jdm jdm added S-awaiting-merge and removed S-tests-failed labels Mar 24, 2015
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 89c208d Mar 24, 2015

saw approval from jdm
at snf@89c208d

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 24, 2015

merging snf/servo/storage_event = 89c208d into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 24, 2015

snf/servo/storage_event = 89c208d merged ok, testing candidate = 2c51d0e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 24, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/1136
success: http://build.servo.org/builders/linux2/builds/1136
success: http://build.servo.org/builders/android/builds/1170
success: http://build.servo.org/builders/mac1/builds/1349
success: http://build.servo.org/builders/mac2/builds/1352
success: http://build.servo.org/builders/gonk/builds/318

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 24, 2015

fast-forwarding master to auto = 2c51d0e
bors-servo pushed a commit that referenced this pull request Mar 24, 2015
bors-servo
auto merge of #5306 : snf/servo/storage_event, r=jdm
Loading status checks…
2c51d0e 
Needed for #5196
@bors-servo bors-servo closed this Mar 24, 2015
@bors-servo bors-servo merged commit 89c208d into servo:master Mar 24, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default all tests passed
@snf snf deleted the snf:storage_event branch Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@snf @highfive @hoppipolla-critic-bot @jdm @bors-servo
You can’t perform that action at this time.