Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake text input relayout when value is changed directly. #5318
Conversation
hoppipolla-critic-bot
commented
Mar 22, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4333 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
I'm new to the codebase, so ignore me if it's not necessary, but it might be nice if there were code comments briefly describing why the force relayout is necessary |
This comment has been minimized.
This comment has been minimized.
jdm
commented on 0db6f85
Mar 23, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging glennw/servo/input-relayout = 0db6f85 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = b7e66c5 |
0db6f85
into
servo:master
glennw commentedMar 22, 2015
No description provided.