Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text input relayout when value is changed directly. #5318

Merged
merged 2 commits into from Mar 24, 2015

Conversation

@glennw
Copy link
Member

glennw commented Mar 22, 2015

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 22, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4333

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Mar 22, 2015

r? @Ms2ger or @jdm

@frewsxcv
Copy link
Member

frewsxcv commented Mar 23, 2015

I'm new to the codebase, so ignore me if it's not necessary, but it might be nice if there were code comments briefly describing why the force relayout is necessary

@jdm

This comment has been minimized.

Copy link

jdm commented on 0db6f85 Mar 23, 2015

r+

@jdm
Copy link
Member

jdm commented Mar 23, 2015

@frewsxcv: I filed #5329 about that; I think it will be better to do it all at once.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 0db6f85 Mar 24, 2015

saw approval from jdm
at glennw@0db6f85

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 24, 2015

merging glennw/servo/input-relayout = 0db6f85 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 24, 2015

glennw/servo/input-relayout = 0db6f85 merged ok, testing candidate = b7e66c5

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 24, 2015

fast-forwarding master to auto = b7e66c5

bors-servo pushed a commit that referenced this pull request Mar 24, 2015
@bors-servo bors-servo closed this Mar 24, 2015
@bors-servo bors-servo merged commit 0db6f85 into servo:master Mar 24, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default all tests passed
@glennw glennw deleted the glennw:input-relayout branch Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.