Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Element.outerHTML setter #5338

Merged
merged 10 commits into from Apr 7, 2015
Merged

Implement Element.outerHTML setter #5338

merged 10 commits into from Apr 7, 2015

Conversation

@ChrisParis
Copy link
Contributor

ChrisParis commented Mar 24, 2015

The first commit refactors the fragment parsing and innerHTML setter. This makes the code mirror the structure of the spec more closely, and also prepares for reusing code with the outerHTML setter.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 24, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4348

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@pcwalton pcwalton force-pushed the servo:master branch from 7f587f6 to b1a35f5 Mar 25, 2015
@metajack
Copy link
Contributor

metajack commented Mar 31, 2015

Assigning @jdm since the remaining open issues were filed by him.
@ChrisParis ChrisParis force-pushed the ChrisParis:outerhtml branch 3 times, most recently from 26b0db3 to d0544b0 Apr 2, 2015
@jdm
Copy link
Member

jdm commented Apr 6, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2015

📌 Commit d0544b0 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2015

🔒 Merge conflict
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2015

☔ The latest upstream changes (presumably #5529) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member

jdm commented Apr 6, 2015

Sorry about the endless rebase treadmill :/
@jdm jdm added S-needs-rebase and removed S-awaiting-merge labels Apr 6, 2015
ChrisParis added 9 commits Mar 21, 2015
@ChrisParis
Refactor fragment parsing
63ced23
@ChrisParis
Implement Element.outerHTML setter
2cc5bad
@ChrisParis
fragment parsing functions take DOMString instead of HTMLInput
cc771fd
@ChrisParis
get rid of and_then in innerHTML setter
3542360
@ChrisParis
get rid of and_then in outerHTML setter
d83f4d8
@ChrisParis
drop try! from parse_fragment
b0ba4d1
@ChrisParis
unwrap AppendChild result in parse_fragment
d1c5ac3
@ChrisParis
Replace spec quotes with spec step numbers
ce16075
@ChrisParis
Remove Root<Node> type annotation in SetOuterHTML
6422f38 
The 'use ... Root' was removed from the file by
another commit, and this annotation wasn't necessary anyway.
@ChrisParis
Produce output of fragment parsing in &mut RootedVec<JS<Node>> argument
Loading status checks…
f76a137
@ChrisParis ChrisParis force-pushed the ChrisParis:outerhtml branch from d0544b0 to f76a137 Apr 6, 2015
@jdm
Copy link
Member

jdm commented Apr 6, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2015

📌 Commit f76a137 has been approved by jdm
@jdm jdm added S-awaiting-merge and removed S-needs-rebase labels Apr 6, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2015

⌛ Testing commit f76a137 with merge b797020...
@Manishearth Manishearth closed this Apr 6, 2015
@Manishearth Manishearth reopened this Apr 6, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

⌛ Testing commit f76a137 with merge b74eba5...
bors-servo pushed a commit that referenced this pull request Apr 7, 2015
bors-servo
Auto merge of #5338 - ChrisParis:outerhtml, r=jdm
b74eba5 
The first commit refactors the fragment parsing and innerHTML setter. This makes the code mirror the structure of the spec more closely, and also prepares for reusing code with the outerHTML setter.
@Manishearth Manishearth closed this Apr 7, 2015
@Manishearth Manishearth reopened this Apr 7, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

⌛ Testing commit f76a137 with merge 505a480...
bors-servo pushed a commit that referenced this pull request Apr 7, 2015
bors-servo
Auto merge of #5338 - ChrisParis:outerhtml, r=jdm
505a480 
The first commit refactors the fragment parsing and innerHTML setter. This makes the code mirror the structure of the spec more closely, and also prepares for reusing code with the outerHTML setter.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

💔 Test failed - linux2
@jdm
Copy link
Member

jdm commented Apr 7, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

⌛ Testing commit f76a137 with merge 45b40d4...
bors-servo pushed a commit that referenced this pull request Apr 7, 2015
bors-servo
Auto merge of #5338 - ChrisParis:outerhtml, r=jdm
Loading status checks…
45b40d4 
The first commit refactors the fragment parsing and innerHTML setter. This makes the code mirror the structure of the spec more closely, and also prepares for reusing code with the outerHTML setter.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit f76a137 into servo:master Apr 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Apr 7, 2015
Merged
@ChrisParis ChrisParis deleted the ChrisParis:outerhtml branch Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@ChrisParis @hoppipolla-critic-bot @metajack @jdm @bors-servo @Ms2ger @Manishearth
You can’t perform that action at this time.