Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send storage event #5419

Merged
merged 1 commit into from Mar 31, 2015
Merged

Send storage event #5419

merged 1 commit into from Mar 31, 2015

Conversation

@snf
Copy link
Contributor

snf commented Mar 27, 2015

Addresses #5196

@highfive
Copy link

highfive commented Mar 27, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 28, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4417

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@snf
Copy link
Contributor Author

snf commented Mar 31, 2015

I think all the issues are solved now, I made some changes by mistake in critic and when trying to undo them I messed the issues a little. Sorry.

@jdm
Copy link
Member

jdm commented Mar 31, 2015

One slight comment nit left!

@snf
Copy link
Contributor Author

snf commented Mar 31, 2015

Done!, squash?

@jdm
Copy link
Member

jdm commented Mar 31, 2015

Yep!

@snf snf force-pushed the snf:send_storage_event branch from 9096fd7 to 880666f Mar 31, 2015
@snf
Copy link
Contributor Author

snf commented Mar 31, 2015

Done!

@jdm
Copy link
Member

jdm commented Mar 31, 2015

Can you squash the test changes too?

@snf snf force-pushed the snf:send_storage_event branch from 880666f to 1cc5bd4 Mar 31, 2015
@snf
Copy link
Contributor Author

snf commented Mar 31, 2015

Better!

@jdm

This comment has been minimized.

Copy link

jdm commented on 1cc5bd4 Mar 31, 2015

r+

@jdm jdm added S-awaiting-merge and removed S-needs-squash labels Mar 31, 2015
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 1cc5bd4 Mar 31, 2015

saw approval from jdm
at snf@1cc5bd4

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 31, 2015

merging snf/servo/send_storage_event = 1cc5bd4 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 31, 2015

snf/servo/send_storage_event = 1cc5bd4 merged ok, testing candidate = c0c5487

This comment has been minimized.

Copy link
Contributor

bors-servo replied Mar 31, 2015

fast-forwarding master to auto = c0c5487

bors-servo pushed a commit that referenced this pull request Mar 31, 2015
Addresses #5196
@bors-servo bors-servo closed this Mar 31, 2015
@bors-servo bors-servo merged commit 1cc5bd4 into servo:master Mar 31, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default all tests passed
@snf snf deleted the snf:send_storage_event branch Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.