Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSend storage event #5419
Send storage event #5419
Conversation
highfive
commented
Mar 27, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon. |
hoppipolla-critic-bot
commented
Mar 28, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4417 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
I think all the issues are solved now, I made some changes by mistake in critic and when trying to undo them I messed the issues a little. Sorry. |
|
One slight comment nit left! |
|
Done!, squash? |
|
Yep! |
|
Done! |
|
Can you squash the test changes too? |
|
Better! |
This comment has been minimized.
This comment has been minimized.
jdm
commented on 1cc5bd4
Mar 31, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging snf/servo/send_storage_event = 1cc5bd4 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = c0c5487 |
1cc5bd4
into
servo:master
snf commentedMar 27, 2015
Addresses #5196