Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a path to --userscripts #5430

Merged
merged 2 commits into from Apr 1, 2015

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 28, 2015

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Mar 28, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4418

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack
Copy link
Contributor

metajack commented Mar 31, 2015

Assigning @kmcallister since @Manishearth pinged him.

@kmcallister
Copy link
Contributor

kmcallister commented Apr 1, 2015

I am the one who asked for this feature :)

@kmcallister
Copy link
Contributor

kmcallister commented Apr 1, 2015

Putting all this logic in HTMLHeadElement seems bad. Let's change that to call into a separate userscript module.

@kmcallister

This comment has been minimized.

A mis-typed path is silently ignored? I think it'd be better to panic, or at least print a warning message.

@kmcallister
Copy link
Contributor

kmcallister commented Apr 1, 2015

r=me with those changes. Thanks for doing this, it'll help with #5260.

@Manishearth Manishearth force-pushed the Manishearth:userscript_path branch from f309cfe to f41acb5 Apr 1, 2015
@Manishearth

This comment has been minimized.

Copy link
Owner Author

Manishearth commented on f41acb5 Apr 1, 2015

r=kmcallister

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on f41acb5 Apr 1, 2015

saw approval from kmcallister
at Manishearth@f41acb5

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 1, 2015

merging Manishearth/servo/userscript_path = f41acb5 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 1, 2015

Manishearth/servo/userscript_path = f41acb5 merged ok, testing candidate = afbc51a

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 1, 2015

fast-forwarding master to auto = afbc51a

bors-servo pushed a commit that referenced this pull request Apr 1, 2015
@bors-servo bors-servo closed this Apr 1, 2015
@bors-servo bors-servo merged commit f41acb5 into servo:master Apr 1, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default all tests passed
@Manishearth Manishearth deleted the Manishearth:userscript_path branch Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.