Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow passing a path to --userscripts #5430
Conversation
hoppipolla-critic-bot
commented
Mar 28, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4418 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Assigning @kmcallister since @Manishearth pinged him. |
|
I am the one who asked for this feature :) |
|
Putting all this logic in |
This comment has been minimized.
This comment has been minimized.
kmcallister
commented on components/script/dom/htmlheadelement.rs in 4d2ca2d
Apr 1, 2015
|
A mis-typed path is silently ignored? I think it'd be better to panic, or at least print a warning message. |
|
r=me with those changes. Thanks for doing this, it'll help with #5260. |
This comment has been minimized.
This comment has been minimized.
|
r=kmcallister |
This comment has been minimized.
This comment has been minimized.
|
saw approval from kmcallister |
This comment has been minimized.
This comment has been minimized.
|
merging Manishearth/servo/userscript_path = f41acb5 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = afbc51a |
f41acb5
into
servo:master
Manishearth commentedMar 28, 2015
r? @kmcallister