Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a replacement for Vec<Root<T>> #5436

Closed
wants to merge 1 commit into from
Closed

Implement a replacement for Vec<Root<T>> #5436

wants to merge 1 commit into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 28, 2015

No description provided.

@highfive
Copy link

highfive commented Mar 28, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@Ms2ger Ms2ger mentioned this pull request Mar 28, 2015
Closed
@Ms2ger Ms2ger closed this Mar 28, 2015
@Ms2ger Ms2ger reopened this Mar 28, 2015
@Ms2ger Ms2ger closed this Mar 28, 2015
@Ms2ger Ms2ger reopened this Mar 28, 2015
@Ms2ger Ms2ger force-pushed the rooted-vec branch from 9010e98 to a644206 Mar 28, 2015
@Ms2ger Ms2ger closed this Mar 28, 2015
@Ms2ger Ms2ger reopened this Mar 28, 2015
@jdm
Copy link
Member

jdm commented Mar 28, 2015

Looks good. Squash!
@jdm jdm added the S-needs-squash label Mar 28, 2015
@mukilan @Ms2ger
Implement RootedVec<T>
Loading status checks…
e8a1e9e
@Ms2ger Ms2ger force-pushed the rooted-vec branch from 895b1be to e8a1e9e Mar 29, 2015
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link
Contributor

Ms2ger commented on e8a1e9e Mar 29, 2015

r+

This comment has been minimized.

Sign in to view
Copy link
Contributor

Ms2ger replied Mar 29, 2015

r=jdm

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

saw approval from Ms2ger, jdm
at e8a1e9e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

merging servo/servo/rooted-vec = e8a1e9e into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

servo/servo/rooted-vec = e8a1e9e merged ok, testing candidate = 08e8ab8

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

saw approval from Ms2ger, jdm
at e8a1e9e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

merging servo/servo/rooted-vec = e8a1e9e into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

servo/servo/rooted-vec = e8a1e9e merged ok, testing candidate = 1282850

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/1198
success: http://build.servo.org/builders/linux2/builds/1196
success: http://build.servo.org/builders/android/builds/1232
success: http://build.servo.org/builders/mac1/builds/1411
success: http://build.servo.org/builders/mac2/builds/1414
success: http://build.servo.org/builders/gonk/builds/378

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

fast-forwarding master to auto = 1282850
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link
Contributor

Ms2ger commented on e8a1e9e Mar 29, 2015

r+

This comment has been minimized.

Sign in to view
Copy link
Contributor

Ms2ger replied Mar 29, 2015

r=jdm

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

saw approval from Ms2ger, jdm
at e8a1e9e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

merging servo/servo/rooted-vec = e8a1e9e into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

servo/servo/rooted-vec = e8a1e9e merged ok, testing candidate = 08e8ab8

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

saw approval from Ms2ger, jdm
at e8a1e9e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

merging servo/servo/rooted-vec = e8a1e9e into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

servo/servo/rooted-vec = e8a1e9e merged ok, testing candidate = 1282850

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/1198
success: http://build.servo.org/builders/linux2/builds/1196
success: http://build.servo.org/builders/android/builds/1232
success: http://build.servo.org/builders/mac1/builds/1411
success: http://build.servo.org/builders/mac2/builds/1414
success: http://build.servo.org/builders/gonk/builds/378

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Mar 29, 2015

fast-forwarding master to auto = 1282850
bors-servo pushed a commit that referenced this pull request Mar 29, 2015
bors-servo
auto merge of #5436 : servo/servo/rooted-vec, r=Ms2ger,jdm
Loading status checks…
08e8ab8
bors-servo pushed a commit that referenced this pull request Mar 29, 2015
bors-servo
auto merge of #5436 : servo/servo/rooted-vec, r=Ms2ger,jdm
Loading status checks…
1282850
@bors-servo bors-servo closed this Mar 29, 2015
@Ms2ger Ms2ger deleted the rooted-vec branch Mar 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-needs-squash
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @jdm @bors-servo @mukilan
You can’t perform that action at this time.