Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement the :focus pseudo-class selector and element.focus/blur #5461
Conversation
highfive
commented
Mar 30, 2015
|
|
|
Added a basic |
hoppipolla-critic-bot
commented
Mar 31, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4455 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Assigned @SimonSapin because he was pinged. |
|
Rolled up into #5519 because of CI brokenness |
Fixes #5460. This supports for simple focusable elements that are their own DOM anchors, like text `input` fields. Requires servo/rust-selectors#20. r? @SimonSapin
|
http://build.servo.org/builders/linux2/builds/1284
|
7ff8d64
to
791fa37
This comment has been minimized.
This comment has been minimized.
|
r=jdm |
This comment has been minimized.
This comment has been minimized.
larsbergstrom
replied
Apr 5, 2015
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging mbrubeck/servo/focus = 791fa37 into auto |
This comment has been minimized.
This comment has been minimized.
|
merging mbrubeck/servo/focus = 791fa37 into auto failed |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging mbrubeck/servo/focus = 791fa37 into auto |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging mbrubeck/servo/focus = 791fa37 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = b63fb0c |
Fixes #5460. This supports for simple focusable elements that are their own DOM anchors, like text `input` fields. Requires servo/rust-selectors#20. r? @SimonSapin
Fixes #5460. This supports for simple focusable elements that are their own DOM anchors, like text `input` fields. Requires servo/rust-selectors#20. r? @SimonSapin
791fa37
into
servo:master
mbrubeck commentedMar 30, 2015
Fixes #5460. This supports for simple focusable elements that are their own DOM anchors, like text
inputfields.Requires servo/rust-selectors#20. r? @SimonSapin