Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the for and event attributes on a script element correctly when o... #5474

Closed
wants to merge 1 commit into from
Closed

Handle the for and event attributes on a script element correctly when o... #5474

wants to merge 1 commit into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 1, 2015

...ne of them is present (fixes #5258).
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 1, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4462

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@Ms2ger Ms2ger mentioned this pull request Apr 1, 2015
Closed
bors-servo pushed a commit that referenced this pull request Apr 1, 2015
bors-servo
auto merge of #5474 : servo/servo/script-for-event, r=Ms2ger
Loading status checks…
9b9c804 
...ne of them is present (fixes #5258).
@KiChjang @Ms2ger
Handle the for and event attributes on a script element correctly whe…
Loading status checks…
fdcf961 
…n one of them is present (fixes #5258).
@Ms2ger Ms2ger force-pushed the script-for-event branch from 6bf2c5e to fdcf961 Apr 1, 2015
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link
Contributor

Ms2ger commented on fdcf961 Apr 1, 2015

r+

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

saw approval from Ms2ger
at fdcf961

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

merging servo/servo/script-for-event = fdcf961 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

servo/servo/script-for-event = fdcf961 merged ok, testing candidate = c85f83f

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

some tests failed:
exception: http://build.servo.org/builders/gonk/builds/418

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

saw approval from Ms2ger
at fdcf961

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

merging servo/servo/script-for-event = fdcf961 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

servo/servo/script-for-event = fdcf961 merged ok, testing candidate = f25604c

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/1241
success: http://build.servo.org/builders/linux2/builds/1239
success: http://build.servo.org/builders/android/builds/1275
success: http://build.servo.org/builders/mac1/builds/1454
success: http://build.servo.org/builders/mac2/builds/1457
success: http://build.servo.org/builders/gonk/builds/420

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

fast-forwarding master to auto = f25604c
@Ms2ger

This comment has been minimized.

Sign in to view
Copy link
Contributor

Ms2ger commented on fdcf961 Apr 1, 2015

r+

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

saw approval from Ms2ger
at fdcf961

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

merging servo/servo/script-for-event = fdcf961 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

servo/servo/script-for-event = fdcf961 merged ok, testing candidate = c85f83f

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

some tests failed:
exception: http://build.servo.org/builders/gonk/builds/418

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

saw approval from Ms2ger
at fdcf961

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

merging servo/servo/script-for-event = fdcf961 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

servo/servo/script-for-event = fdcf961 merged ok, testing candidate = f25604c

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

all tests pass:
success: http://build.servo.org/builders/linux1/builds/1241
success: http://build.servo.org/builders/linux2/builds/1239
success: http://build.servo.org/builders/android/builds/1275
success: http://build.servo.org/builders/mac1/builds/1454
success: http://build.servo.org/builders/mac2/builds/1457
success: http://build.servo.org/builders/gonk/builds/420

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 1, 2015

fast-forwarding master to auto = f25604c
bors-servo pushed a commit that referenced this pull request Apr 1, 2015
bors-servo
auto merge of #5474 : servo/servo/script-for-event, r=Ms2ger
Loading status checks…
c85f83f 
...ne of them is present (fixes #5258).
bors-servo pushed a commit that referenced this pull request Apr 1, 2015
bors-servo
auto merge of #5474 : servo/servo/script-for-event, r=Ms2ger
Loading status checks…
f25604c 
...ne of them is present (fixes #5258).
@bors-servo bors-servo closed this Apr 1, 2015
@Ms2ger Ms2ger deleted the script-for-event branch Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Script for/event attributes should only be considered if they're both present.
5 participants
@Ms2ger @hoppipolla-critic-bot @bors-servo @jdm @KiChjang
You can’t perform that action at this time.