Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11 clipboard support #5479

Closed
wants to merge 10 commits into from
Closed

Conversation

@aweinstock314
Copy link
Contributor

aweinstock314 commented Apr 1, 2015

Relevant to issue #5376

Depends on pull request servo/rust-xlib#36

Also depends on an external repository https://github.com/aweinstock314/rust-x11-clipboard, should this be moved into servo's github namespace?

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 1, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4468

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Apr 1, 2015

$ ./mach test-tidy
components/script/textinput.rs:130: trailing whitespace
@jdm
Copy link
Member

jdm commented Apr 1, 2015

Why's the rust-xlib dependency needed in script?

@pcwalton
Copy link
Contributor

pcwalton commented Apr 1, 2015

r-

This is going to prevent sandboxing, since it accesses X from within the script task.

@jdm
Copy link
Member

jdm commented Apr 2, 2015

Reviewed on Critic!

@aweinstock314
Copy link
Contributor Author

aweinstock314 commented Apr 2, 2015

In response to https://critic.hoppipolla.co.uk/showcomment?chain=11501 :

It could be recreated on-demand, but that would involve creating/closing the X11 Display/window each time. I hadn't measured to see if that's a performance issue in practice, it just seemed like the sort of thing that ought to be cached.

…o facilitate sandboxing.
@jdm
Copy link
Member

jdm commented Apr 2, 2015

Two small style nits left, then we'll need to wait on the rust-xlib PR.

…o facilitate sandboxing.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 6, 2015

Please rebase this PR and then reopen. It has been temporarily closed to avoid generating excessive work for GitHub's servers.

bors-servo pushed a commit that referenced this pull request Apr 21, 2015
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase).

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Apr 21, 2015
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase).

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Apr 21, 2015
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase).

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this pull request Apr 21, 2015
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase).

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.