Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upX11 clipboard support #5479
X11 clipboard support #5479
Conversation
hoppipolla-critic-bot
commented
Apr 1, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4468 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
Why's the rust-xlib dependency needed in script? |
|
r- This is going to prevent sandboxing, since it accesses X from within the script task. |
…itate sandboxing.
|
Reviewed on Critic! |
|
In response to https://critic.hoppipolla.co.uk/showcomment?chain=11501 : It could be recreated on-demand, but that would involve creating/closing the X11 Display/window each time. I hadn't measured to see if that's a performance issue in practice, it just seemed like the sort of thing that ought to be cached. |
…o facilitate sandboxing.
|
Two small style nits left, then we'll need to wait on the rust-xlib PR. |
…o facilitate sandboxing.
|
Please rebase this PR and then reopen. It has been temporarily closed to avoid generating excessive work for GitHub's servers. |
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547) <!-- Reviewable:end -->
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547) <!-- Reviewable:end -->
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547) <!-- Reviewable:end -->
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547) <!-- Reviewable:end -->
aweinstock314 commentedApr 1, 2015
Relevant to issue #5376
Depends on pull request servo/rust-xlib#36
Also depends on an external repository https://github.com/aweinstock314/rust-x11-clipboard, should this be moved into servo's github namespace?