Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular pipelines #550

Merged
merged 5 commits into from Jul 3, 2013
Merged

Modular pipelines #550

merged 5 commits into from Jul 3, 2013

Conversation

@tikue
Copy link

tikue commented Jun 28, 2013

When loading pages, the constellation spawns a new script<-->layout<-->renderer pipeline that loads in the background while scripts continue executing on the currently loaded page.

@tikue
Copy link
Author

tikue commented Jun 28, 2013

r? pcwalton

Tim Kuehn added 5 commits Jun 27, 2013
script caches last loaded url -- currently no caching policy
naive caching of render layers for near-instant forward/back
handling evicted pipelines is currently broken
@pcwalton
Copy link
Contributor

pcwalton commented Jul 3, 2013

As I mentioned before, Constellation should probably be renamed Browser (other name suggestions welcome), at least in the context of the task, because the Browser task handles all constellations.

@tikue
Copy link
Author

tikue commented Jul 3, 2013

Yes, I agree, but I think the current implementation actually only represents a single constellation. In other words, the browser does not yet exist, because we don't have multiple tabs and windows yet.

@metajack

This comment has been minimized.

Copy link

metajack commented on 6f7107e Jul 3, 2013

r+

@metajack
Copy link
Contributor

metajack commented Jul 3, 2013

The code looks good.

I had one issue that I think you can resolve in a future PR. Currently a non-copyable token is given to the renderer to allow it to send paint messages. However, this token is never used. Instead, the paint message sends an id which is not tied to the token at all.

The renderer should have to send the token with the paint message, or something derived from the token, otherwise, we might as well use a boolean piece of state and just have messages that indicate only the state changes.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 6f7107e Jul 3, 2013

saw approval from metajack
at tikue@6f7107e

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 3, 2013

merging tkuehn/servo/master = 6f7107e into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 3, 2013

tkuehn/servo/master = 6f7107e merged ok, testing candidate = 213d9a0

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 3, 2013

fast-forwarding master to auto = 213d9a0

bors-servo pushed a commit that referenced this pull request Jul 3, 2013
When loading pages, the constellation spawns a new script<-->layout<-->renderer pipeline that loads in the background while scripts continue executing on the currently loaded page.
@bors-servo bors-servo merged commit 6f7107e into servo:master Jul 3, 2013
1 check passed
1 check passed
default all tests passed
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
…tting-a-form

Add tests for the form resetting
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
update copy_pixels to use stride data

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/550)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.