Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upModular pipelines #550
Modular pipelines #550
Conversation
|
r? pcwalton |
|
As I mentioned before, |
|
Yes, I agree, but I think the current implementation actually only represents a single constellation. In other words, the browser does not yet exist, because we don't have multiple tabs and windows yet. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 6f7107e
Jul 3, 2013
|
r+ |
|
The code looks good. I had one issue that I think you can resolve in a future PR. Currently a non-copyable token is given to the renderer to allow it to send paint messages. However, this token is never used. Instead, the paint message sends an id which is not tied to the token at all. The renderer should have to send the token with the paint message, or something derived from the token, otherwise, we might as well use a boolean piece of state and just have messages that indicate only the state changes. |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging tkuehn/servo/master = 6f7107e into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 213d9a0 |
When loading pages, the constellation spawns a new script<-->layout<-->renderer pipeline that loads in the background while scripts continue executing on the currently loaded page.
6f7107e
into
servo:master
…tting-a-form Add tests for the form resetting
update copy_pixels to use stride data <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/550) <!-- Reviewable:end -->
tikue commentedJun 28, 2013
When loading pages, the constellation spawns a new script<-->layout<-->renderer pipeline that loads in the background while scripts continue executing on the currently loaded page.