Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quasiquotes for attributes in `plugins` crate. #5509

Closed
wants to merge 1 commit into from
Closed

Use quasiquotes for attributes in `plugins` crate. #5509

wants to merge 1 commit into from

Conversation

@utkarshkukreti
Copy link
Contributor

utkarshkukreti commented Apr 3, 2015

Fixes #5157.
@highfive
Copy link

highfive commented Apr 3, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 3, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4504

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
components/plugins/jstraceable.rs Outdated
add_attr("jstraceable");
item2.attrs.push(quote_attr!(cx, #![must_root]));
item2.attrs.push(quote_attr!(cx, #![privatize]));
item2.attrs.push(quote_attr!(cx, #![jstraceable]));

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Apr 3, 2015

Member

There should not be any exclamation mark

This comment has been minimized.

Sign in to view
@Manishearth

Manishearth Apr 3, 2015

Member

(on any of the attributes -- all are being used as outer attrs)
@Manishearth
Copy link
Member

Manishearth commented Apr 3, 2015

Looks good, just need to remove the exclamation marks.

Thanks!
@utkarshkukreti
Use quasiquotes for attributes in `plugins` crate.
Loading status checks…
f31d06e 
Fixes #5157.
@utkarshkukreti utkarshkukreti force-pushed the utkarshkukreti:use-quasiquote-for-attributes branch from ec4feeb to f31d06e Apr 3, 2015
@utkarshkukreti
Copy link
Contributor Author

utkarshkukreti commented Apr 3, 2015

@Manishearth done! (The tests were passing so I didn't notice.)
@Manishearth

This comment has been minimized.

Sign in to view
Copy link
Member

Manishearth commented on f31d06e Apr 3, 2015

r+

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 4, 2015

saw approval from Manishearth
at utkarshkukreti@f31d06e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 4, 2015

merging utkarshkukreti/servo/use-quasiquote-for-attributes = f31d06e into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 4, 2015

merging utkarshkukreti/servo/use-quasiquote-for-attributes = f31d06e into auto failed
@Manishearth
Copy link
Member

Manishearth commented Apr 3, 2015

Oh, probably because we're directly inserting them so the inner/outer ness doesn't matter
@Manishearth

This comment has been minimized.

Sign in to view
Copy link

Manishearth commented on f31d06e Apr 4, 2015

r+
@Manishearth Manishearth mentioned this pull request Apr 4, 2015
Closed
@Manishearth
Copy link
Member

Manishearth commented Apr 4, 2015

Rolled up into #5519 because of CI brokenness
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 4, 2015

Rebased as #5523
@Ms2ger Ms2ger closed this Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Use quasiquote for attributes in plugin crate
7 participants
@utkarshkukreti @highfive @hoppipolla-critic-bot @Manishearth @Ms2ger @bors-servo @jdm
You can’t perform that action at this time.