Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd detection for page loads. #552
Merged
+56
−12
Conversation
|
This looks good. It doesn't necessarily need to be part of this PR, but it seems to me that there are two immediately useful additions here:
If you feel like adding that stuff to this PR, great; otherwise, I may take a crack at it once this is merged. |
|
(I went ahead and symbolically r+'d this, but I assume bors won't merge it since it needs a rebase.) |
bors-servo
pushed a commit
that referenced
this pull request
Jul 11, 2013
This comment has been minimized.
This comment has been minimized.
|
r=pcwalton |
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging metajack/servo/detect-page-loaded = 6ab28c8 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 17fcf80 |
bors-servo
pushed a commit
that referenced
this pull request
Jul 11, 2013
bors-servo
merged commit 6ab28c8
into
servo:master
1 check passed
1 check passed
default
all tests passed
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Flatten the display list in the API This changes brings the WebRender API more into line with the Servo display list and also the frames generated inside WebRender itself. Most intermediate display list representations are removed as well as their place on the resource cache. Perhaps most notably, stacking contexts are started via a PushStackingContext display item and ended via a PopStackingContext item. Additionally, the flatten pass has been significantly simplified to account for these changes. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/552) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedJun 28, 2013
This doesn't do anything, but adds the stuff to detect the page load. This will be needed to write out the composited texture to PNGs for reftests.
r? @Sfowler