Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CPU rendering with texture upload on the renderer side. #553

Merged
merged 1 commit into from Oct 26, 2013

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jun 28, 2013

@@ -115,7 +115,7 @@ fn run(opts: &Opts) {
// Create the compositor.
let (compositor_port, compositor_chan) = comm::stream();
let compositor_chan = CompositorChan::new(compositor_chan);
CompositorTask::create(compositor_port, profiler_chan.clone(), shutdown_chan);
CompositorTask::create(compositor_port, copy *opts, profiler_chan.clone(), shutdown_chan);

This comment has been minimized.

@metajack

metajack Jul 3, 2013

Contributor

Should this be opts.clone()?

@metajack
Copy link
Contributor

metajack commented Jul 3, 2013

@pcwalton sharegl is missing extern mod extra;

@eschweic eschweic mentioned this pull request Jul 3, 2013
@metajack
Copy link
Contributor

metajack commented Jul 8, 2013

This needs a rebase.

@pcwalton
Copy link
Contributor Author

pcwalton commented Oct 24, 2013

Here's a rebase.

r? @metajack

@pcwalton

This comment has been minimized.

Copy link
Owner Author

pcwalton commented on 3d0bfa5 Oct 25, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 3d0bfa5 Oct 26, 2013

saw approval from pcwalton
at pcwalton@3d0bfa5

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 26, 2013

merging pcwalton/servo/cpu-rendering = 3d0bfa5 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 26, 2013

pcwalton/servo/cpu-rendering = 3d0bfa5 merged ok, testing candidate = 4eb1e88

This comment has been minimized.

Copy link
Contributor

bors-servo replied Oct 26, 2013

fast-forwarding master to auto = 4eb1e88

@bors-servo bors-servo merged commit 3d0bfa5 into servo:master Oct 26, 2013
1 check passed
1 check passed
default all tests passed
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
…tion

Add tests for notification attributes and method
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Revert "Update `ipc-channel` dependency to 0.6"

This reverts commit 7c4f0af.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/553)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.