Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upX11 clipboard support #5547
X11 clipboard support #5547
Conversation
hoppipolla-critic-bot
commented
Apr 6, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4534 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Just waiting on servo/rust-xlib#36 at this point. @aweinstock314 could you update https://github.com/servo/servo/blob/master/README.md#prerequisites as well? |
|
|
|
It looks like servo/rust-xlib#36 has gone unmerged for a while, and #5566 seems to imply that rust-xlib is unmaintained/in the process of being replaced. Should I revise this to depend on https://github.com/Daggerbot/x11-rs (and submit a PR to x11-rs to add the clipboard-related constants)? |
|
Until we actually transition to using rust-xlib everywhere, I'm in favour of continuing to add to it. I didn't notice that servo/rust-xlib#36 was now working on Travis; I'm going to go ahead and merge it. |
|
Go ahead and squash this while rebasing! |
aweinstock314
force-pushed the
aweinstock314:x11-clipboard
branch
from
6432aaf
to
a3bdd71
|
@bors-servo: r+ |
|
|
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547) <!-- Reviewable:end -->
|
|
aweinstock314
force-pushed the
aweinstock314:x11-clipboard
branch
from
f544fbe
to
658927f
|
|
|
@bors-servo: r+ |
|
|
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547) <!-- Reviewable:end -->
|
|
|
|
|
Whoops. test-unit is broken by these changes; we probably need an optional constellation channel instead. |
…he signature expected by the unit tests.
This comment has been minimized.
This comment has been minimized.
jdm
commented on components/script/textinput.rs in cf6aef5
Apr 21, 2015
|
Why not move this into the previous block and skip the mutable, optional binding? |
|
I tried that, it won't allow borrowing self (for self.insert_string) since cc is already borrowed. |
|
@bors-servo: r+ |
|
|
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase). <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5547) <!-- Reviewable:end -->
aweinstock314 commentedApr 6, 2015
Manual re-opening of #5479 (since it seems that GitHub disables re-opening with the same number after a rebase).