Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup cef/wrappers.rs. #5570

Merged
merged 6 commits into from Apr 8, 2015
Merged

Cleanup cef/wrappers.rs. #5570

merged 6 commits into from Apr 8, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 7, 2015

No description provided.

Ms2ger added 6 commits Apr 7, 2015
@Ms2ger
Remove some unnecessary transmute calls.
dd7ec69
@Ms2ger
Use boxed::into_raw where it makes sense.
b5d41aa
@Ms2ger
Use raw::Slice where it makes sense.
cba3b68
@Ms2ger
Allocate only as much as necessary.
1fa1950
@Ms2ger
Stop leaking the Vec.
6d1cde2
@Ms2ger
Use size_t for the arguments to malloc.
Loading status checks…
9ddaf82
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 7, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4565

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@tetsuharuohzeki
Copy link
Member

tetsuharuohzeki commented Apr 7, 2015

@bors-servo r+
@jdm
Copy link
Member

jdm commented Apr 7, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

📌 Commit 9ddaf82 has been approved by saneyuki
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

📌 Commit 9ddaf82 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

⌛ Testing commit 9ddaf82 with merge 1977807...
bors-servo pushed a commit that referenced this pull request Apr 8, 2015
bors-servo
Auto merge of #5570 - Ms2ger:cef, r=jdm
1977807
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

💔 Test failed - linux2
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 8, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

⌛ Testing commit 9ddaf82 with merge 6f30c66...
bors-servo pushed a commit that referenced this pull request Apr 8, 2015
bors-servo
Auto merge of #5570 - Ms2ger:cef, r=jdm
6f30c66
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

💔 Test failed - linux2
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 8, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

⌛ Testing commit 9ddaf82 with merge 8c80bc2...
bors-servo pushed a commit that referenced this pull request Apr 8, 2015
bors-servo
Auto merge of #5570 - Ms2ger:cef, r=jdm
8c80bc2
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

💔 Test failed - mac1
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 8, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

⌛ Testing commit 9ddaf82 with merge 37b6738...
bors-servo pushed a commit that referenced this pull request Apr 8, 2015
bors-servo
Auto merge of #5570 - Ms2ger:cef, r=jdm
Loading status checks…
37b6738
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 9ddaf82 into servo:master Apr 8, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:cef branch Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @hoppipolla-critic-bot @tetsuharuohzeki @jdm @bors-servo
You can’t perform that action at this time.