Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit tests to their own crates, cut time by 96% #5574

Merged
merged 12 commits into from Apr 8, 2015
Merged

Move unit tests to their own crates, cut time by 96% #5574

merged 12 commits into from Apr 8, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Apr 7, 2015

On my laptop, running ./mach test-unit goes from about 11 minutes to 22 seconds, when run after ./mach build.

Fix #5291.
@highfive
Copy link

highfive commented Apr 7, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@metajack metajack closed this Apr 7, 2015
@metajack metajack reopened this Apr 7, 2015
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 7, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4570

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

☔ The latest upstream changes (presumably #5005) made this pull request unmergeable. Please resolve the merge conflicts.
@Manishearth
Copy link
Member

Manishearth commented Apr 7, 2015

@bors-servo: p=10

(Won't do anything yet, but if this gets approved it should merge immediately)
SimonSapin added 3 commits Apr 7, 2015
@SimonSapin @jdm
Move util crate unit tests into a new unit_tests crate
6d5406e
@SimonSapin @jdm
Move gfx unit tests to the unit_tests crate.
e0b98a3
@SimonSapin @jdm
Move net::cookie unit tests into the unit_tests crate.
6912226
@jdm jdm force-pushed the unit-tests branch from 768b924 to 48c850d Apr 7, 2015
@metajack
Copy link
Contributor

metajack commented Apr 7, 2015

@SimonSapin reviewed in Critic.
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 7, 2015

Issues addressed.
SimonSapin added 9 commits Apr 7, 2015
@SimonSapin
Move net::{data_loader,image_cache_task} unit tests into the unit_tes…
d88770e 
…ts crate.
@SimonSapin
Move net::resource_task unit tests into the unit_tests crate.
e27c967
@SimonSapin
Move style crate unit tests into the unit_tests crate.
e5466a3
@SimonSapin
Move script crate unit tests into the unit_tests crate.
dc431c9
@SimonSapin
Have `./mach test-unit` run nothing but `cargo test -p unit_tests`
ec28d98 
All unit tests will move there, and it should be much faster to build
than every other crate together.

Fix #5291.
@SimonSapin
Add license headers in tests/unit
3b1cfe8
@SimonSapin
Check license headers in ./tests
2a6f2cd
@SimonSapin
Remove now-empty module.
9199c4f
@SimonSapin
Use the correct license header.
Loading status checks…
84e5f1e
@SimonSapin SimonSapin force-pushed the unit-tests branch from d580e80 to 84e5f1e Apr 7, 2015
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 7, 2015

@bors-servo: r=jack 84e5f1e
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

⌛ Testing commit 84e5f1e with merge 8803171...
bors-servo pushed a commit that referenced this pull request Apr 7, 2015
bors-servo
Auto merge of #5574 - servo:unit-tests, r=jack
8803171 
On my laptop, running `./mach test-unit` goes from about 11 minutes to 22 seconds, when run after `./mach build`.

Fix #5291.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

💔 Test failed - mac2
@jdm
Copy link
Member

jdm commented Apr 7, 2015

Mac builder doesn't appear to be logged in, or can't otherwise initialize video things.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 8, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

⚡ Previous build results for android, gonk, linux1, linux2 are reusable. Rebuilding only mac1, mac2...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

💔 Test failed - mac1
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 8, 2015

@bors-servo: retry
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 8, 2015

The physical servo-mac1 machine is having issues with freezing after the upgrade. The MacStadium folks are looking at it; until then just running everything on servo-mac2.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

⌛ Testing commit 84e5f1e with merge 017d105...
bors-servo pushed a commit that referenced this pull request Apr 8, 2015
bors-servo
Auto merge of #5574 - servo:unit-tests, r=jack
Loading status checks…
017d105 
On my laptop, running `./mach test-unit` goes from about 11 minutes to 22 seconds, when run after `./mach build`.

Fix #5291.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 84e5f1e into master Apr 8, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Apr 8, 2015
Merged
Merged
@SimonSapin SimonSapin deleted the unit-tests branch Apr 8, 2015
@SimonSapin SimonSapin mentioned this pull request Apr 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Move unit tests to dedicated crates
8 participants
@SimonSapin @highfive @hoppipolla-critic-bot @bors-servo @Manishearth @metajack @jdm @larsbergstrom
You can’t perform that action at this time.