Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Temporary iterator in Node::collect_text_contents() #5578

Merged
merged 1 commit into from Apr 8, 2015

Conversation

@nox
Copy link
Member

nox commented Apr 7, 2015

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 7, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4572

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 7, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Apr 7, 2015

📌 Commit cdb3efe has been approved by Ms2ger

bors-servo pushed a commit that referenced this pull request Apr 8, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

Testing commit cdb3efe with merge 656617a...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit cdb3efe into servo:master Apr 8, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:collect_text_contents-unsound branch Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.