Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated paint message policy and removed unnecessary render layer buffer set cloning #558

Closed
wants to merge 3 commits into from
Closed

updated paint message policy and removed unnecessary render layer buffer set cloning #558

wants to merge 3 commits into from

Conversation

@tikue
Copy link

tikue commented Jul 3, 2013

  • constellation grants permission to renderers instead of passing tokens
  • render tasks wrap layer buffer sets in ARCs
  • removed no-longer-used field (constellation chan) from render task struct
Tim Kuehn added 2 commits Jul 3, 2013
Tim Kuehn
permission bool replaces compositor token
6ba2f8d
Tim Kuehn
render task no longer copies the layer buffer sets before sending pai…
dc8e3cb 
…nt messages -- uses an ARC instead
src/components/gfx/render_task.rs

// FIXME: rust/#5967
let mut render_task = RenderTask {
id: id,
port: port.take(),
compositor: compositor,
font_ctx: @mut FontContext::new(opts.render_backend,
font_ctx: @mut FontContext::new(copy opts.render_backend,

This comment has been minimized.

Sign in to view
@metajack

metajack Jul 3, 2013

Contributor

This should be .clone()
src/components/main/compositing/mod.rs Outdated
let buffers = util::replace(&mut new_layer_buffer_set.buffers, ~[]);

for buffers.each |buffer| {
for new_layer_buffer_set.buffers.each |buffer| {

This comment has been minimized.

Sign in to view
@metajack

metajack Jul 3, 2013

Contributor

Does ARC not support the new iteration syntax yet? With .advance?
@metajack
Copy link
Contributor

metajack commented Jul 3, 2013

This will be r+ with the above addressed/answered.
Tim Kuehn
removed unused constellation chan from render task
Loading status checks…
1f55db9
@tikue
Copy link
Author

tikue commented Jul 3, 2013

  • fixed layer_buffer_set.each --> layer_buffer_set.iter().advance
  • will put in pr for azure to add #deriving[clone] to BackendType
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on 1f55db9 Jul 4, 2013

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 1f55db9 Jul 4, 2013

saw approval from metajack
at tikue@1f55db9

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jul 4, 2013

merging tkuehn/servo/master = 1f55db9 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jul 4, 2013

tkuehn/servo/master = 1f55db9 merged ok, testing candidate = 32c147f

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jul 4, 2013

all tests pass:
http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/99
http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/53

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jul 4, 2013

fast-forwarding master to auto = 32c147f
bors-servo pushed a commit that referenced this pull request Jul 4, 2013
bors-servo
auto merge of #558 : tkuehn/servo/master, r=metajack
32c147f 
* constellation grants permission to renderers instead of passing tokens
* render tasks wrap layer buffer sets in ARCs
* removed no-longer-used field (constellation chan) from render task struct
@bors-servo bors-servo closed this Jul 4, 2013
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
@bors-servo
Auto merge of servo#572 - glennw:no-ipc-for-you, r=pcwalton
b2a15e8 
Make ipc-channel an optional feature.

This allows clients to opt-in to IPC for communication if required.

Otherwise, in-process rust channels are used, avoiding serialization.

This fixes servo#558.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/572)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@tikue @metajack @bors-servo
You can’t perform that action at this time.