Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dirty flag on hover or focus change #5589

Merged
merged 1 commit into from Apr 8, 2015
Merged

Set dirty flag on hover or focus change #5589

merged 1 commit into from Apr 8, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 7, 2015

This fixes a bug where styles are not recalculated immediately when an element's hover or focus state changes. I'm not sure how to write an automated test for this. r? @glennw or @pcwalton
@mbrubeck
Set dirty flag on hover or focus change
Loading status checks…
3d7dad2
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 7, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4581

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@pcwalton
Copy link
Contributor

pcwalton commented Apr 8, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

📌 Commit 3d7dad2 has been approved by pcwalton
@Manishearth
Copy link
Member

Manishearth commented Apr 8, 2015

@bors-servo: p=1
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

⌛ Testing commit 3d7dad2 with merge f9c8073...
bors-servo pushed a commit that referenced this pull request Apr 8, 2015
bors-servo
Auto merge of #5589 - mbrubeck:dirty, r=pcwalton
f9c8073 
This fixes a bug where styles are not recalculated immediately when an element's hover or focus state changes.  I'm not sure how to write an automated test for this.  r? @glennw or @pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

💔 Test failed - linux2
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 8, 2015

Intermittent failure:

Unexpected Results
==================

/2dcontext/shadows/canvas_shadows_002.htm
-----------------------------------------
FAIL [Parent]

Tracked in: #5207
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 8, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

⌛ Testing commit 3d7dad2 with merge a745dda...
bors-servo pushed a commit that referenced this pull request Apr 8, 2015
bors-servo
Auto merge of #5589 - mbrubeck:dirty, r=pcwalton
Loading status checks…
a745dda 
This fixes a bug where styles are not recalculated immediately when an element's hover or focus state changes.  I'm not sure how to write an automated test for this.  r? @glennw or @pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 3d7dad2 into servo:master Apr 8, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:dirty branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@mbrubeck @hoppipolla-critic-bot @pcwalton @bors-servo @Manishearth @larsbergstrom @jdm
You can’t perform that action at this time.