Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow disabled fields to be focused #5592

Merged
merged 1 commit into from Apr 10, 2015
Merged

Don't allow disabled fields to be focused #5592

merged 1 commit into from Apr 10, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 8, 2015

This begins implementing parts of the focusing steps algorithm. r? @jdm or @Ms2ger
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 8, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4583

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@mbrubeck mbrubeck mentioned this pull request Apr 8, 2015
Closed
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Apr 8, 2015

Note: the newly-failing tests here will be fixed when we implement tabindex (#5603) and contenteditable.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 9, 2015

☔ The latest upstream changes (presumably #5590) made this pull request unmergeable. Please resolve the merge conflicts.
@mbrubeck mbrubeck force-pushed the mbrubeck:focusable branch from bbfaa29 to 6a24314 Apr 9, 2015
components/script/dom/element.rs
if self.is_actually_disabled() {
return false;
}
// TODO: Check whether the element is being rendered (i.e. not hidden).

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Apr 10, 2015

Member

Might want to file followups for these later (potentially E-Easy)
@mbrubeck
Don't allow disabled fields to be focused
Loading status checks…
4e63a50
@mbrubeck mbrubeck force-pushed the mbrubeck:focusable branch from 6a24314 to 4e63a50 Apr 10, 2015
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Apr 10, 2015

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2015

📌 Commit 4e63a50 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2015

⌛ Testing commit 4e63a50 with merge a8b0fb1...
bors-servo pushed a commit that referenced this pull request Apr 10, 2015
bors-servo
Auto merge of #5592 - mbrubeck:focusable, r=jdm
Loading status checks…
a8b0fb1 
This begins implementing parts of the [focusing steps](https://html.spec.whatwg.org/multipage/interaction.html#focusing-steps) algorithm. r? @jdm or @Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Apr 10, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 4e63a50 into servo:master Apr 10, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck deleted the mbrubeck:focusable branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@mbrubeck @hoppipolla-critic-bot @bors-servo @Manishearth @jdm @highfive
You can’t perform that action at this time.