Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable canvas_shadows_002.htm. #5605

Merged
merged 1 commit into from Apr 8, 2015
Merged

Disable canvas_shadows_002.htm. #5605

merged 1 commit into from Apr 8, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 8, 2015

CC #5207.

CC #5207.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 8, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4594

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 8, 2015

@bors-servo: p=10

@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 8, 2015

r+

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 8, 2015

@bors-servo: r=mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

📌 Commit 211d40c has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

Testing commit 211d40c with merge 88aa07b...

bors-servo pushed a commit that referenced this pull request Apr 8, 2015
CC #5207.
@bors-servo
Copy link
Contributor

bors-servo commented Apr 8, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit 211d40c into master Apr 8, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the shadows branch Apr 10, 2015
@nox
Copy link
Member

nox commented Jan 11, 2016

I guess the rectangle is drawn before the image finished loading?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.