Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enough Webdriver support to enable Get(). #5610

Merged
merged 1 commit into from Apr 16, 2015
Merged

Add enough Webdriver support to enable Get(). #5610

merged 1 commit into from Apr 16, 2015

Conversation

@jgraham
Copy link
Contributor

jgraham commented Apr 8, 2015

This is incomplete in several ways:

  • It assumes that there's only one constellation (i.e. top level browsing context), ever.
  • The session support is very basic indeed (no capabilities)
  • Passing channels over channels may not sit well with IPC
  • The error handling is mostly missing

Review on Reviewable
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 8, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4599

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jgraham jgraham mentioned this pull request Apr 8, 2015
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2015

☔ The latest upstream changes (presumably #5489) made this pull request unmergeable. Please resolve the merge conflicts.
@jgraham jgraham force-pushed the jgraham:jgraham/webdriver-get branch from c04b0ea to dc90b1e Apr 16, 2015
@jdm
Copy link
Member

jdm commented Apr 16, 2015

Squash!
@jgraham
Add enough Webdriver support to enable Get().
Loading status checks…
009e2ba 
This is incomplete in several ways:

* It assumes that there's only one constellation (i.e. top level browsing context), ever.
* The session support is very basic indeed (no capabilities)
* Passing channels over channels may not sit well with IPC
* The error handling is mostly missing
@jgraham jgraham force-pushed the jgraham:jgraham/webdriver-get branch from dc90b1e to 009e2ba Apr 16, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 16, 2015

@bors-servo: r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2015

📌 Commit 009e2ba has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2015

⌛ Testing commit 009e2ba with merge af2f46b...
bors-servo pushed a commit that referenced this pull request Apr 16, 2015
bors-servo
Auto merge of #5610 - jgraham:jgraham/webdriver-get, r=jdm
Loading status checks…
af2f46b 
This is incomplete in several ways:

* It assumes that there's only one constellation (i.e. top level browsing context), ever.
* The session support is very basic indeed (no capabilities)
* Passing channels over channels may not sit well with IPC
* The error handling is mostly missing

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5610)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 009e2ba into servo:master Apr 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Apr 16, 2015
Merged
Merged
@jdm jdm mentioned this pull request Apr 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jgraham @hoppipolla-critic-bot @bors-servo @jdm @Ms2ger @highfive
You can’t perform that action at this time.