Replace GLUT with GLFW #563

metajack · 2013-07-04T18:58:57Z

This code replaces glut with glfw. The motivation here is address the GPU driver bugs on Linux when using multiple Display * pointers with shared GL contexts instead of a single common one. GLFW has native access methods which provide access to its Display *, which appears to be unique among all the similar toolkits.

Details:

Adds glfw and glfw-rs to the build
Removes GLUT code and replaces it with GLFW versions
Fixes hard coded initial window values
Fixes clean targets
Event loop doesn't block on windowing events anymore


        Add glfw and glfw-rs to servo build.


        Fix clean targets.


        Replace glut with glfw.

Also fixes initial window size to get based on the windowing code instead of being hardcoded everywhere. This code works on HiDPI displays, but does not appropriately scale the output up yet.

metajack · 2013-07-04T18:59:25Z

r? @pcwalton

jeaye · 2013-07-04T22:20:03Z

This is very cool.

brendanzab · 2013-07-05T00:14:07Z

Glad to be of service, let me know if you need any more assistance!

jdm · 2013-07-08T15:33:12Z

Can we get rid of set_composite_callback now?

metajack · 2013-07-08T15:47:41Z

I'll do that.

jdm · 2013-07-08T15:53:11Z

r+

bors-servo · 2013-07-08T15:54:39Z

saw approval from jdm
at metajack@e0e5e1a

bors-servo · 2013-07-08T15:54:41Z

merging metajack/servo/glfw = e0e5e1a into auto

bors-servo · 2013-07-08T15:54:43Z

metajack/servo/glfw = e0e5e1a merged ok, testing candidate = d2580a4

bors-servo · 2013-07-08T16:01:15Z

some tests failed:
http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/54


        auto merge of #563 : metajack/servo/glfw, r=jdm

This code replaces glut with glfw. The motivation here is address the GPU driver bugs on Linux when using multiple `Display *` pointers with shared GL contexts instead of a single common one. GLFW has native access methods which provide access to its `Display *`, which appears to be unique among all the similar toolkits. Details: - Adds glfw and glfw-rs to the build - Removes GLUT code and replaces it with GLFW versions - Fixes hard coded initial window values - Fixes clean targets - Event loop doesn't block on windowing events anymore


        Update to latest Rust.

jdm · 2013-07-09T21:09:13Z

r+

bors-servo · 2013-07-09T21:12:35Z

saw approval from jdm
at metajack@870db39

bors-servo · 2013-07-09T21:12:37Z

merging metajack/servo/glfw = 870db39 into auto

bors-servo · 2013-07-09T21:12:39Z

metajack/servo/glfw = 870db39 merged ok, testing candidate = 15b6443

bors-servo · 2013-07-09T21:15:37Z

some tests failed:
http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/57


        auto merge of #563 : metajack/servo/glfw, r=jdm

This code replaces glut with glfw. The motivation here is address the GPU driver bugs on Linux when using multiple `Display *` pointers with shared GL contexts instead of a single common one. GLFW has native access methods which provide access to its `Display *`, which appears to be unique among all the similar toolkits. Details: - Adds glfw and glfw-rs to the build - Removes GLUT code and replaces it with GLFW versions - Fixes hard coded initial window values - Fixes clean targets - Event loop doesn't block on windowing events anymore


        Add Makefile trigger for forcing clean-rust to happen.

metajack · 2013-07-09T22:27:01Z

r+

metajack · 2013-07-10T01:57:58Z

@bors: retry

metajack · 2013-07-10T02:42:41Z

@bors: retry

metajack · 2013-07-10T03:19:52Z

@bors: retry

metajack · 2013-07-10T13:54:23Z

@bors: retry

bors-servo · 2013-07-09T22:28:01Z

saw approval from metajack
at metajack@cfc7491

bors-servo · 2013-07-09T22:28:05Z

merging metajack/servo/glfw = cfc7491 into auto

bors-servo · 2013-07-09T22:28:08Z

metajack/servo/glfw = cfc7491 merged ok, testing candidate = f0d0a30

bors-servo · 2013-07-09T23:06:37Z

some tests failed:
http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/104

bors-servo · 2013-07-10T02:00:35Z

saw approval from metajack
at metajack@cfc7491

bors-servo · 2013-07-10T13:57:33Z

saw approval from metajack
at metajack@cfc7491

bors-servo · 2013-07-10T13:57:35Z

merging metajack/servo/glfw = cfc7491 into auto

bors-servo · 2013-07-10T13:57:37Z

metajack/servo/glfw = cfc7491 merged ok, testing candidate = 34a3505

bors-servo · 2013-07-10T14:33:36Z

all tests pass:
http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/108
http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/62

bors-servo · 2013-07-10T14:36:39Z

fast-forwarding master to auto = 34a3505


        auto merge of #563 : metajack/servo/glfw, r=metajack

This code replaces glut with glfw. The motivation here is address the GPU driver bugs on Linux when using multiple `Display *` pointers with shared GL contexts instead of a single common one. GLFW has native access methods which provide access to its `Display *`, which appears to be unique among all the similar toolkits. Details: - Adds glfw and glfw-rs to the build - Removes GLUT code and replaces it with GLFW versions - Fixes hard coded initial window values - Fixes clean targets - Event loop doesn't block on windowing events anymore


        auto merge of #563 : metajack/servo/glfw, r=metajack

This code replaces glut with glfw. The motivation here is address the GPU driver bugs on Linux when using multiple `Display *` pointers with shared GL contexts instead of a single common one. GLFW has native access methods which provide access to its `Display *`, which appears to be unique among all the similar toolkits. Details: - Adds glfw and glfw-rs to the build - Removes GLUT code and replaces it with GLFW versions - Fixes hard coded initial window values - Fixes clean targets - Event loop doesn't block on windowing events anymore


        auto merge of #563 : metajack/servo/glfw, r=metajack

This code replaces glut with glfw. The motivation here is address the GPU driver bugs on Linux when using multiple `Display *` pointers with shared GL contexts instead of a single common one. GLFW has native access methods which provide access to its `Display *`, which appears to be unique among all the similar toolkits. Details: - Adds glfw and glfw-rs to the build - Removes GLUT code and replaces it with GLFW versions - Fixes hard coded initial window values - Fixes clean targets - Event loop doesn't block on windowing events anymore


        auto merge of #563 : metajack/servo/glfw, r=metajack

This code replaces glut with glfw. The motivation here is address the GPU driver bugs on Linux when using multiple `Display *` pointers with shared GL contexts instead of a single common one. GLFW has native access methods which provide access to its `Display *`, which appears to be unique among all the similar toolkits. Details: - Adds glfw and glfw-rs to the build - Removes GLUT code and replaces it with GLFW versions - Fixes hard coded initial window values - Fixes clean targets - Event loop doesn't block on windowing events anymore


        auto merge of #563 : metajack/servo/glfw, r=metajack

This code replaces glut with glfw. The motivation here is address the GPU driver bugs on Linux when using multiple `Display *` pointers with shared GL contexts instead of a single common one. GLFW has native access methods which provide access to its `Display *`, which appears to be unique among all the similar toolkits. Details: - Adds glfw and glfw-rs to the build - Removes GLUT code and replaces it with GLFW versions - Fixes hard coded initial window values - Fixes clean targets - Event loop doesn't block on windowing events anymore

brendanzab · 2013-07-10T14:43:19Z

Hurrah, at last! :D


        Merge pull request servo#563 from w3c/pr/291

FileAPI FileReader interface tests added; r=zcorpan


        Auto merge of servo#563 - vvuk:compiled-in-shaders, r=glennw

compile in shaders to webrender instead of requiring a res directory Fixes issue servo#352. res directory can be used to override.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/563)

metajack added 3 commits Jul 4, 2013

Add glfw and glfw-rs to servo build.

1230282

Fix clean targets.

39e759f

Replace glut with glfw.

Loading status checks…

e0e5e1a

Also fixes initial window size to get based on the windowing code instead of being hardcoded everywhere. This code works on HiDPI displays, but does not appropriately scale the output up yet.

Update to latest Rust.

Loading status checks…

870db39

Add Makefile trigger for forcing clean-rust to happen.

Loading status checks…

cfc7491

jdm mentioned this pull request Jul 10, 2013

fixed fallout from the recent rust update afflicting the profiler #559

Merged

bors-servo merged commit cfc7491 into servo:master Jul 10, 2013
1 check passed

1 check passed

default all tests passed

jdm mentioned this pull request Jul 10, 2013

Servo is crashing immediately #536

Closed

metajack deleted the metajack:glfw branch Jul 10, 2013

ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014

Merge pull request servo#563 from w3c/pr/291

1e8796e

FileAPI FileReader interface tests added; r=zcorpan

servo / servo

Join GitHub today

Replace GLUT with GLFW #563

Replace GLUT with GLFW #563

Conversation

metajack commented Jul 4, 2013

metajack commented Jul 4, 2013

jeaye commented Jul 4, 2013

brendanzab commented Jul 5, 2013

This comment has been minimized.

jdm commented on src/components/main/compositing/mod.rs in e0e5e1a Jul 8, 2013

metajack commented Jul 8, 2013

This comment has been minimized.

jdm commented on e0e5e1a Jul 8, 2013

This comment has been minimized.

bors-servo commented on e0e5e1a Jul 8, 2013

This comment has been minimized.

bors-servo replied Jul 8, 2013

This comment has been minimized.

bors-servo replied Jul 8, 2013

This comment has been minimized.

bors-servo replied Jul 8, 2013

This comment has been minimized.

jdm commented on 870db39 Jul 9, 2013

This comment has been minimized.

bors-servo commented on 870db39 Jul 9, 2013

This comment has been minimized.

bors-servo replied Jul 9, 2013

This comment has been minimized.

bors-servo replied Jul 9, 2013

This comment has been minimized.

bors-servo replied Jul 9, 2013

This comment has been minimized.

metajack commented on cfc7491 Jul 9, 2013

This comment has been minimized.

metajack replied Jul 10, 2013

This comment has been minimized.

metajack replied Jul 10, 2013

This comment has been minimized.

metajack replied Jul 10, 2013

This comment has been minimized.

metajack replied Jul 10, 2013

This comment has been minimized.

bors-servo commented on cfc7491 Jul 9, 2013

This comment has been minimized.

bors-servo replied Jul 9, 2013

This comment has been minimized.

bors-servo replied Jul 9, 2013

This comment has been minimized.

bors-servo replied Jul 9, 2013

This comment has been minimized.

bors-servo replied Jul 10, 2013

This comment has been minimized.

bors-servo replied Jul 10, 2013

This comment has been minimized.

bors-servo replied Jul 10, 2013

This comment has been minimized.

bors-servo replied Jul 10, 2013

This comment has been minimized.

bors-servo replied Jul 10, 2013

This comment has been minimized.

bors-servo replied Jul 10, 2013

brendanzab commented Jul 10, 2013

jdm commented on `src/components/main/compositing/mod.rs` in `e0e5e1a` Jul 8, 2013

jdm commented on `e0e5e1a` Jul 8, 2013

bors-servo commented on `e0e5e1a` Jul 8, 2013

jdm commented on `870db39` Jul 9, 2013

bors-servo commented on `870db39` Jul 9, 2013

metajack commented on `cfc7491` Jul 9, 2013

bors-servo commented on `cfc7491` Jul 9, 2013