Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some as_slice calls in cef. #5662

Merged
merged 1 commit into from Apr 13, 2015
Merged

Remove some as_slice calls in cef. #5662

merged 1 commit into from Apr 13, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 13, 2015

Review on Reviewable
@Ms2ger
Remove some as_slice calls in cef.
Loading status checks…
066cf8e
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 13, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4653

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 13, 2015

Reviewed files:

  • ports/cef/command_line.rs @ r1
  • ports/cef/window.rs @ r1

Comments from the review on Reviewable.io
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 13, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 13, 2015

📌 Commit 066cf8e has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Apr 13, 2015

⌛ Testing commit 066cf8e with merge d16b102...
bors-servo pushed a commit that referenced this pull request Apr 13, 2015
bors-servo
Auto merge of #5662 - Ms2ger:cef-core, r=larsbergstrom
Loading status checks…
d16b102 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5662)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 13, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 066cf8e into servo:master Apr 13, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:cef-core branch Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @hoppipolla-critic-bot @larsbergstrom @bors-servo @highfive
You can’t perform that action at this time.