Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a submodule for rust-cssparser #568
Merged
Conversation
|
PR updated with a repository under github.com/mozilla-servo and re-licensed to MPL2. |
bors-servo
pushed a commit
that referenced
this pull request
Jul 10, 2013
[As discussed](https://github.com/mozilla/servo/wiki/Meeting-2013-07-01#css), even though this parser is not used yet, having it built and tested with the rest of Servo helps ensure it does not bitrot.
Even though this parser is not used yet, having it built and tested with the rest of Servo helps ensure it does not bitrot.
|
PR updated again for Rust language changes. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on d754893
Jul 10, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging SimonSapin/servo/rust-cssparser-in-tree = d754893 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 1f7c738 |
bors-servo
pushed a commit
that referenced
this pull request
Jul 10, 2013
[As discussed](https://github.com/mozilla/servo/wiki/Meeting-2013-07-01#css), even though this parser is not used yet, having it built and tested with the rest of Servo helps ensure it does not bitrot.
bors-servo
merged commit d754893
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Fix typo in event_loadstart.html.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Use strongly typed geometry - Part 1 Part one of a series of pull requests to convert untyped geometry into strongly typed geometry. This PR adds LayerPixel, ParentLayerPixel and WorldPixel, as well as the corresponging Rect, Point and Size structures, and converts good chunk of the Rect<f32> that I could identify as LayerRect. In order to avoid churn in the public API, I postponed converting most of the webrender_trait types, but this will be done as soon as the webrender internals are properly typed. As a result of the step-by-step approach, this PR adds some unpleasant ```LayerFoo::from_untyped``` and ```foo.to_untyped``` at places, but the end goal is to have almost none of them in the end. I hope to land things progressively, though, because this type of changeset is time-consuming to rebase. The added units are inspired from gecko's units (Layer/ParentLayer) and some of the webrneder terminology (World). Don't hesitate to propose other names. This needs a careful review, in particular for LayerPixel vs ParentLayerPixel. r? @glennw @kvark @staktrace <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/568) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedJul 10, 2013
As discussed, even though this parser is not used yet, having it built and tested with the rest of Servo helps ensure it does not bitrot.