Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start running reftests with wptrunner. #5687

Merged
merged 1 commit into from Apr 30, 2015
Merged

Start running reftests with wptrunner. #5687

merged 1 commit into from Apr 30, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 14, 2015

CC #5618.

Review on Reviewable
@jdm
Copy link
Member

jdm commented Apr 14, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2015

📌 Commit c4d0e93 has been approved by jdm
bors-servo pushed a commit that referenced this pull request Apr 14, 2015
bors-servo
Auto merge of #5687 - Ms2ger:css, r=jdm
c852cbd 
CC #5618.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5687)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2015

⌛ Testing commit c4d0e93 with merge c852cbd...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2015

💔 Test failed - linux1
@Ms2ger Ms2ger force-pushed the Ms2ger:css branch from c4d0e93 to 427ec5b Apr 14, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 14, 2015

@bors-servo: r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2015

📌 Commit 427ec5b has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2015

⌛ Testing commit 427ec5b with merge 0312c3b...
bors-servo pushed a commit that referenced this pull request Apr 14, 2015
bors-servo
Auto merge of #5687 - Ms2ger:css, r=jdm
0312c3b 
CC #5618.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5687)
<!-- Reviewable:end -->
@Ms2ger Ms2ger mentioned this pull request Apr 14, 2015
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2015

💔 Test failed - mac2
@jdm
Copy link
Member

jdm commented Apr 14, 2015

I tried to look into this but I can't figure out how to run serve.py locally and run any tests under _mozilla.
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 15, 2015

So if you run a single test, Servo remains open and while it's open, you can access the server (though not directory listings) with ./mach run
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2015

☔ The latest upstream changes (presumably #5546) made this pull request unmergeable. Please resolve the merge conflicts.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 28, 2015

To run this locally by itself, you do:

./mach test-wpt _mozilla/css/abs_float_pref_width.html --log-raw=something.log

And then can plug something.log into: http://hoppipolla.co.uk/410/reftest-analyser-structured.xhtml

It appears that pixels around the edge of the box are "fuzzy" in the floated version that uses the ahem font to make the big green square, and only on OSX (this test passes on Linux).
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 28, 2015

@pcwalton Have you seen anything where font rendering is fuzzy on OSX, particularly with ahem, as if it has been floated to a fractional position?

The file at https://github.com/Ms2ger/servo/blob/427ec5bdbae3a54b10932dfafdd8b087039fd46d/tests/wpt/mozilla/tests/css/abs_float_pref_width.html renders a green square, but the pixels at column 99 (which should be white) appear to be about 2/3 saturated green. Similarly, the pixels at column 300 differ.
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 28, 2015

I'm not surprised that aligning on fractional pixels would cause issues, but this test appears to pass fine in the rust harness?
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 29, 2015

Needs:

 -Z disable-text-aa

As used in: https://github.com/servo/servo/blob/master/tests/reftest.rs#L254-L256

I confirmed that without that flag we get the identical failing behavior in the current codebase, and with the flag things appear to work correctly (from the commandline, at least).

cc @jgraham
@jgraham
Copy link
Contributor

jgraham commented Apr 29, 2015

https://critic.hoppipolla.co.uk/r/4848
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 30, 2015

#5901
@Ms2ger
Start running reftests with wptrunner.
Loading status checks…
031d4f0 
CC #5618.
@Ms2ger Ms2ger force-pushed the Ms2ger:css branch from 427ec5b to 5fdf38b Apr 30, 2015
@Ms2ger Ms2ger force-pushed the Ms2ger:css branch from 5fdf38b to 031d4f0 Apr 30, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 30, 2015

@bors-servo: r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2015

📌 Commit 031d4f0 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2015

⌛ Testing commit 031d4f0 with merge b5b0ef5...
bors-servo pushed a commit that referenced this pull request Apr 30, 2015
bors-servo
Auto merge of #5687 - Ms2ger:css, r=jdm
Loading status checks…
b5b0ef5 
CC #5618.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5687)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 031d4f0 into servo:master Apr 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @jdm @bors-servo @larsbergstrom @jgraham @highfive
You can’t perform that action at this time.