Move content tests into the Servo wpt tree (fixes #5686). #5700

Ms2ger · 2015-04-15T14:01:33Z

hoppipolla-critic-bot · 2015-04-15T14:01:41Z

Critic review: https://critic.hoppipolla.co.uk/r/4683

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

jdm · 2015-04-15T15:30:15Z

Reviewed files:

tests/content/resources/iframe_contentDocument_inner.html @ r1
tests/content/test.jpg @ r1
tests/content/test.png @ r1
tests/content/test_blob.html @ r1
tests/content/test_body_listener.html @ r1
tests/content/test_caption.html @ r1
tests/content/test_characterdata.html @ r1
tests/content/test_click_prevent.html @ r1
tests/content/test_collections.html @ r1
tests/content/test_create_element.html @ r1
tests/content/test_createElement_script.html @ r1
tests/content/test_document_activeElement.html @ r1
tests/content/test_document_body.html @ r1
tests/content/test_document_characterSet.html @ r1
tests/content/test_document_characterSet_default.html @ r1
tests/content/test_document_characterSet_invalid.html @ r1
tests/content/test_document_compatMode_loose.html @ r1
tests/content/test_document_compatMode_strict.html @ r1
tests/content/test_document_contenttype.html @ r1
tests/content/test_document_datalist_options.html @ r1
tests/content/test_document_defaultView.html @ r1
tests/content/test_document_getElementById.html @ r1
tests/content/test_document_getElementsByName.html @ r1
tests/content/test_document_head.html @ r1
tests/content/test_document_images_cache.html @ r1
tests/content/test_document_implementation.html @ r1
tests/content/test_document_links_cache.html @ r1
tests/content/test_document_readystate.html @ r1
tests/content/test_document_set_node_value.html @ r1
tests/content/test_document_title_nontextchildren.html @ r1
tests/content/test_document_url.html @ r1
tests/content/test_documentElement.html @ r1
tests/content/test_DOMParser.html @ r1
tests/content/test_domtokenlist.html @ r1
tests/content/test_element_attribute.html @ r1
tests/content/test_element_attributes.html @ r1
tests/content/test_element_classList.html @ r1
tests/content/test_element_className.html @ r1
tests/content/test_element_matches.html @ r1
tests/content/test_empty_clientrect.html @ r1
tests/content/test_enabled_disabled_selectors.html @ r1
tests/content/test_Event.html @ r1
tests/content/test_event_dispatch.html @ r1
tests/content/test_event_dispatch_dynamic.html @ r1
tests/content/test_event_dispatch_order.html @ r1
tests/content/test_event_handler_syntax_error.html @ r1
tests/content/test_event_listener.html @ r1
tests/content/test_focus_blur.html @ r1
tests/content/test_getBoundingClientRect.html @ r1
tests/content/test_getPropertyPriority.html @ r1
tests/content/test_global.html @ r1
tests/content/test_htmlcollection.html @ r1
tests/content/test_htmlfieldsetelement_elements.html @ r1
tests/content/test_htmlspacechars.html @ r1
tests/content/test_iframe_contentDocument.html @ r1
tests/content/test_img_width_height.html @ r1
tests/content/test_inline_event_handler.html @ r1
tests/content/test_innerHTML.html @ r1
tests/content/test_interfaces.html @ r1
tests/content/test_lenient_this.html @ r1
tests/content/test_load_event.html @ r1
tests/content/test_MouseEvent.html @ r1
tests/content/test_navigator.html @ r1
tests/content/test_node_cloneNode.html @ r1
tests/content/test_node_compareDocumentPosition.html @ r1
tests/content/test_node_contains.html @ r1
tests/content/test_node_insertBefore.html @ r1
tests/content/test_node_isEqualNode.html @ r1
tests/content/test_node_normalize.html @ r1
tests/content/test_node_replaceChild.html @ r1
tests/content/test_parentNode_querySelector.html @ r1
tests/content/test_parentNode_querySelectorAll.html @ r1
tests/content/test_parentnodes.html @ r1
tests/content/test_proxy_setter.html @ r1
tests/content/test_script_type.html @ r1
tests/content/test_storage.html @ r1
tests/content/test_textcontent.html @ r1
tests/content/test_title.html @ r1
tests/content/test_trace_null.html @ r1
tests/content/test_union.html @ r1
tests/content/test_window.html @ r1
tests/content/test_window_performance.html @ r1
tests/content/test_window_setInterval.html @ r1
tests/content/test_windowproxy.html @ r1
tests/wpt/mozilla/meta/MANIFEST.json @ r1
tests/wpt/mozilla/tests/mozilla/blob.html @ r1
tests/wpt/mozilla/tests/mozilla/body_listener.html @ r1
tests/wpt/mozilla/tests/mozilla/caption.html @ r1
tests/wpt/mozilla/tests/mozilla/characterdata.html @ r1
tests/wpt/mozilla/tests/mozilla/click_prevent.html @ r1
tests/wpt/mozilla/tests/mozilla/collections.html @ r1
tests/wpt/mozilla/tests/mozilla/create_element.html @ r1
tests/wpt/mozilla/tests/mozilla/createElement_script.html @ r1
tests/wpt/mozilla/tests/mozilla/document_activeElement.html @ r1
tests/wpt/mozilla/tests/mozilla/document_body.html @ r1
tests/wpt/mozilla/tests/mozilla/document_characterSet.html @ r1
tests/wpt/mozilla/tests/mozilla/document_characterSet_default.html @ r1
tests/wpt/mozilla/tests/mozilla/document_characterSet_invalid.html @ r1
tests/wpt/mozilla/tests/mozilla/document_compatMode_loose.html @ r1
tests/wpt/mozilla/tests/mozilla/document_compatMode_strict.html @ r1
tests/wpt/mozilla/tests/mozilla/document_contenttype.html @ r1
tests/wpt/mozilla/tests/mozilla/document_datalist_options.html @ r1
tests/wpt/mozilla/tests/mozilla/document_defaultView.html @ r1
tests/wpt/mozilla/tests/mozilla/document_getElementById.html @ r1
tests/wpt/mozilla/tests/mozilla/document_getElementsByName.html @ r1
tests/wpt/mozilla/tests/mozilla/document_head.html @ r1
tests/wpt/mozilla/tests/mozilla/document_images_cache.html @ r1
tests/wpt/mozilla/tests/mozilla/document_implementation.html @ r1
tests/wpt/mozilla/tests/mozilla/document_links_cache.html @ r1
tests/wpt/mozilla/tests/mozilla/document_readystate.html @ r1
tests/wpt/mozilla/tests/mozilla/document_set_node_value.html @ r1
tests/wpt/mozilla/tests/mozilla/document_title_nontextchildren.html @ r1
tests/wpt/mozilla/tests/mozilla/document_url.html @ r1
tests/wpt/mozilla/tests/mozilla/documentElement.html @ r1
tests/wpt/mozilla/tests/mozilla/DOMParser.html @ r1
tests/wpt/mozilla/tests/mozilla/domtokenlist.html @ r1
tests/wpt/mozilla/tests/mozilla/element_attribute.html @ r1
tests/wpt/mozilla/tests/mozilla/element_attributes.html @ r1
tests/wpt/mozilla/tests/mozilla/element_classList.html @ r1
tests/wpt/mozilla/tests/mozilla/element_className.html @ r1
tests/wpt/mozilla/tests/mozilla/element_matches.html @ r1
tests/wpt/mozilla/tests/mozilla/empty_clientrect.html @ r1
tests/wpt/mozilla/tests/mozilla/enabled_disabled_selectors.html @ r1
tests/wpt/mozilla/tests/mozilla/Event.html @ r1
tests/wpt/mozilla/tests/mozilla/event_dispatch.html @ r1
tests/wpt/mozilla/tests/mozilla/event_dispatch_dynamic.html @ r1
tests/wpt/mozilla/tests/mozilla/event_dispatch_order.html @ r1
tests/wpt/mozilla/tests/mozilla/event_handler_syntax_error.html @ r1
tests/wpt/mozilla/tests/mozilla/event_listener.html @ r1
tests/wpt/mozilla/tests/mozilla/focus_blur.html @ r1
tests/wpt/mozilla/tests/mozilla/getBoundingClientRect.html @ r1
tests/wpt/mozilla/tests/mozilla/getPropertyPriority.html @ r1
tests/wpt/mozilla/tests/mozilla/global.html @ r1
tests/wpt/mozilla/tests/mozilla/htmlcollection.html @ r1
tests/wpt/mozilla/tests/mozilla/htmlfieldsetelement_elements.html @ r1
tests/wpt/mozilla/tests/mozilla/htmlspacechars.html @ r1
tests/wpt/mozilla/tests/mozilla/iframe_contentDocument.html @ r1
tests/wpt/mozilla/tests/mozilla/img_width_height.html @ r1
tests/wpt/mozilla/tests/mozilla/inline_event_handler.html @ r1
tests/wpt/mozilla/tests/mozilla/innerHTML.html @ r1
tests/wpt/mozilla/tests/mozilla/interfaces.html @ r1
tests/wpt/mozilla/tests/mozilla/lenient_this.html @ r1
tests/wpt/mozilla/tests/mozilla/load_event.html @ r1
tests/wpt/mozilla/tests/mozilla/MouseEvent.html @ r1
tests/wpt/mozilla/tests/mozilla/navigator.html @ r1
tests/wpt/mozilla/tests/mozilla/node_cloneNode.html @ r1
tests/wpt/mozilla/tests/mozilla/node_compareDocumentPosition.html @ r1
tests/wpt/mozilla/tests/mozilla/node_contains.html @ r1
tests/wpt/mozilla/tests/mozilla/node_insertBefore.html @ r1
tests/wpt/mozilla/tests/mozilla/node_isEqualNode.html @ r1
tests/wpt/mozilla/tests/mozilla/node_normalize.html @ r1
tests/wpt/mozilla/tests/mozilla/node_replaceChild.html @ r1
tests/wpt/mozilla/tests/mozilla/parentNode_querySelector.html @ r1
tests/wpt/mozilla/tests/mozilla/parentNode_querySelectorAll.html @ r1
tests/wpt/mozilla/tests/mozilla/parentnodes.html @ r1
tests/wpt/mozilla/tests/mozilla/proxy_setter.html @ r1
tests/wpt/mozilla/tests/mozilla/resources/iframe_contentDocument_inner.html @ r1
tests/wpt/mozilla/tests/mozilla/script_type.html @ r1
tests/wpt/mozilla/tests/mozilla/storage.html @ r1
tests/wpt/mozilla/tests/mozilla/test.jpg @ r1
tests/wpt/mozilla/tests/mozilla/test.png @ r1
tests/wpt/mozilla/tests/mozilla/textcontent.html @ r1
tests/wpt/mozilla/tests/mozilla/title.html @ r1
tests/wpt/mozilla/tests/mozilla/trace_null.html @ r1
tests/wpt/mozilla/tests/mozilla/union.html @ r1
tests/wpt/mozilla/tests/mozilla/window.html @ r1
tests/wpt/mozilla/tests/mozilla/window_performance.html @ r1
tests/wpt/mozilla/tests/mozilla/window_setInterval.html @ r1
tests/wpt/mozilla/tests/mozilla/windowproxy.html @ r1

^{tests/wpt/mozilla/tests/mozilla/document_characterSet_default.html, line 9 [r1] (raw file):}
Let's make this an expected failure.

^{tests/wpt/mozilla/tests/mozilla/element_attributes.html, line 13 [r1] (raw file):}
Indentation.

^{tests/wpt/mozilla/tests/mozilla/enabled_disabled_selectors.html, line 86 [r1] (raw file):}
Add an expected failure?

^{tests/wpt/mozilla/tests/mozilla/script_type.html, line 101 [r1] (raw file):}
Make these assert_unreached or whatever it is?

^{tests/wpt/mozilla/tests/mozilla/trace_null.html, line 2 [r1] (raw file):}
Hmm?

^{tests/wpt/mozilla/tests/mozilla/windowproxy.html, line 17 [r1] (raw file):}
Make this an expected failure.

Comments from the review on Reviewable.io

jdm · 2015-04-15T20:04:58Z

Reviewed files:

tests/wpt/mozilla/meta/MANIFEST.json @ r2
tests/wpt/mozilla/meta/mozilla/enabled_disabled_selectors.html.ini @ r2
tests/wpt/mozilla/meta/mozilla/windowproxy.html.ini @ r2
tests/wpt/mozilla/tests/mozilla/document_characterSet_default.html @ r2
tests/wpt/mozilla/tests/mozilla/element_attributes.html @ r2
tests/wpt/mozilla/tests/mozilla/enabled_disabled_selectors.html @ r2
tests/wpt/mozilla/tests/mozilla/htmlcollection.html @ r2
tests/wpt/mozilla/tests/mozilla/trace_null.html @ r2
tests/wpt/mozilla/tests/mozilla/windowproxy.html @ r2

Comments from the review on Reviewable.io

jdm · 2015-04-15T20:05:18Z

Squash!


        Move content tests into the Servo wpt tree (fixes #5686).

Ms2ger · 2015-04-15T20:08:48Z

@bors-servo: r=jdm

bors-servo · 2015-04-15T20:08:49Z

📌 Commit 48ac95c has been approved by jdm

bors-servo · 2015-04-15T20:19:41Z

⌛ Testing commit 48ac95c with merge 8fd8fe3...


        Auto merge of #5700 - Ms2ger:content, r=jdm

[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5700)

bors-servo · 2015-04-15T20:52:36Z

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2


        Stop running content tests.

They have all been moved into test-wpt in <servo/servo#5700>.

highfive added the S-awaiting-review label Apr 15, 2015

jdm added S-needs-code-changes and removed S-awaiting-review labels Apr 15, 2015

highfive added S-awaiting-review and removed S-needs-code-changes labels Apr 15, 2015

jdm added S-needs-squash and removed S-awaiting-review labels Apr 15, 2015

Move content tests into the Servo wpt tree (fixes #5686).

Loading status checks…

48ac95c

Ms2ger force-pushed the Ms2ger:content branch from bbd39d2 to 48ac95c Apr 15, 2015

highfive added the S-awaiting-review label Apr 15, 2015

bors-servo merged commit 48ac95c into servo:master Apr 15, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

Ms2ger added a commit to servo/saltfs that referenced this pull request Apr 16, 2015

Stop running content tests.

cb4291c

They have all been moved into test-wpt in <servo/servo#5700>.

Ms2ger mentioned this pull request Apr 16, 2015

Stop running content tests. servo/saltfs#27

Merged

Ms2ger deleted the Ms2ger:content branch Apr 16, 2015

servo / servo

Move content tests into the Servo wpt tree (fixes #5686). #5700

Move content tests into the Servo wpt tree (fixes #5686). #5700

Ms2ger commented Apr 15, 2015

hoppipolla-critic-bot commented Apr 15, 2015

jdm commented Apr 15, 2015

jdm commented Apr 15, 2015

jdm commented Apr 15, 2015

Ms2ger commented Apr 15, 2015

bors-servo commented Apr 15, 2015

bors-servo commented Apr 15, 2015

bors-servo commented Apr 15, 2015

servo / servo

Join GitHub today

Move content tests into the Servo wpt tree (fixes #5686). #5700

Move content tests into the Servo wpt tree (fixes #5686). #5700

Conversation

Ms2ger commented Apr 15, 2015

hoppipolla-critic-bot commented Apr 15, 2015

jdm commented Apr 15, 2015

jdm commented Apr 15, 2015

jdm commented Apr 15, 2015

Ms2ger commented Apr 15, 2015

bors-servo commented Apr 15, 2015

bors-servo commented Apr 15, 2015

bors-servo commented Apr 15, 2015