Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish implementation of ChildNode and ParentNode #5721

Merged
merged 1 commit into from Apr 16, 2015
Merged

Finish implementation of ChildNode and ParentNode #5721

merged 1 commit into from Apr 16, 2015

Conversation

@nox
Copy link
Member

nox commented Apr 16, 2015

Review on Reviewable
@nox
Finish implementation of ChildNode and ParentNode
Loading status checks…
45e1b96
@nox nox mentioned this pull request Apr 16, 2015
Closed
@jdm
Copy link
Member

jdm commented Apr 16, 2015

Reviewed files:

  • components/script/dom/characterdata.rs @ r1
  • components/script/dom/document.rs @ r1
  • components/script/dom/documentfragment.rs @ r1
  • components/script/dom/documenttype.rs @ r1
  • components/script/dom/element.rs @ r1
  • components/script/dom/node.rs @ r1
  • components/script/dom/webidls/ChildNode.webidl @ r1
  • components/script/dom/webidls/ParentNode.webidl @ r1
  • tests/wpt/metadata/dom/interfaces.html.ini @ r1
  • tests/wpt/metadata/dom/nodes/getElementsByClassName-31.htm.ini @ r1
  • tests/wpt/metadata/html/dom/interfaces.html.ini @ r1

Comments from the review on Reviewable.io
@jdm
Copy link
Member

jdm commented Apr 16, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2015

📌 Commit 45e1b96 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2015

⌛ Testing commit 45e1b96 with merge 4fd4370...
bors-servo pushed a commit that referenced this pull request Apr 16, 2015
bors-servo
Auto merge of #5721 - nox:nodeorstring, r=jdm
Loading status checks…
4fd4370 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5721)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 45e1b96 into servo:master Apr 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:nodeorstring branch Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nox @jdm @bors-servo @highfive
You can’t perform that action at this time.