Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings in net unit tests #5734

Merged
merged 1 commit into from Apr 17, 2015
Merged

Conversation

@marcusklaas
Copy link
Contributor

marcusklaas commented Apr 17, 2015

This closes issue #5709.

Review on Reviewable

@highfive
Copy link

highfive commented Apr 17, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 17, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4715

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Apr 17, 2015

$ ./mach test-tidy
tests/unit/net/mime_classifier.rs:14: tab on line
tests/unit/net/mime_classifier.rs:15: tab on line
tests/unit/net/mime_classifier.rs:17: tab on line
tests/unit/net/mime_classifier.rs:19: tab on line
tests/unit/net/mime_classifier.rs:47: trailing whitespace
@marcusklaas
Copy link
Contributor Author

marcusklaas commented Apr 17, 2015

Aaah, will take care of those things promptly.

@jdm
Copy link
Member

jdm commented Apr 17, 2015

Reviewed files:

  • tests/unit/lib.rs @ r1
  • tests/unit/net/image_cache_task.rs @ r1
  • tests/unit/net/mime_classifier.rs @ r1

tests/unit/net/mime_classifier.rs, line 60 [r1] (raw file):
If we use {:?} here, I think we can just use filename instead of filename_string.



Comments from the review on Reviewable.io

@marcusklaas
Copy link
Contributor Author

marcusklaas commented Apr 17, 2015

I updated the pull request, but by amending my initial commit. Apparently reviewable doesn't like this. Should I just have added new commits?

@jdm
Copy link
Member

jdm commented Apr 17, 2015

My understanding is that reviewable is supposed to support that. @larsbergstrom?

@jdm
Copy link
Member

jdm commented Apr 17, 2015

Actually it looks like reviewable handled it just fine!

@jdm
Copy link
Member

jdm commented Apr 17, 2015

Reviewed files:

  • tests/unit/net/mime_classifier.rs @ r2

Comments from the review on Reviewable.io

@jdm
Copy link
Member

jdm commented Apr 17, 2015

@marcusklaas
Copy link
Contributor Author

marcusklaas commented Apr 17, 2015

Cool, I just got this by reading @hoppipolla-critic-bot's comment in this thread.

@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2015

📌 Commit 0d482e3 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2015

Testing commit 0d482e3 with merge 2b3acd1...

bors-servo pushed a commit that referenced this pull request Apr 17, 2015
This closes issue #5709.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5734)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit 0d482e3 into servo:master Apr 17, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@marcusklaas marcusklaas deleted the marcusklaas:issue-5709 branch Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.