Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix compiler warnings in net unit tests #5734
Conversation
highfive
commented
Apr 17, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon. |
hoppipolla-critic-bot
commented
Apr 17, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4715 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
Aaah, will take care of those things promptly. |
|
Reviewed files:
tests/unit/net/mime_classifier.rs, line 60 [r1] (raw file): Comments from the review on Reviewable.io |
|
I updated the pull request, but by amending my initial commit. Apparently reviewable doesn't like this. Should I just have added new commits? |
|
My understanding is that reviewable is supposed to support that. @larsbergstrom? |
|
Actually it looks like reviewable handled it just fine! |
|
Reviewed files:
Comments from the review on Reviewable.io |
|
@bors-servo: r+ |
|
Cool, I just got this by reading @hoppipolla-critic-bot's comment in this thread. |
|
|
This closes issue #5709. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5734) <!-- Reviewable:end -->
marcusklaas commentedApr 17, 2015
This closes issue #5709.