Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix infinite bindings generation #574
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
jdm
commented on ebbfde0
Jul 10, 2013
|
r+ |
|
This is effectively the same solution I came up with in #573. |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging metajack/servo/bindgen-deps = ebbfde0 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = c085a93 |
bors-servo
pushed a commit
that referenced
this pull request
Jul 10, 2013
This touches the `.rs` files even if they don't change. This will cause libscript to rebuild sometimes even when it doesn't have to. This seems better than having bindgen run every time as the case where CodegenRust.py changes but doesn't change the output `.rs` seems like it should be rare. r? @jdm
bors-servo
merged commit ebbfde0
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Add a test for methods that do nothing.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedJul 10, 2013
This touches the
.rsfiles even if they don't change. This will cause libscript to rebuild sometimes even when it doesn't have to. This seems better than having bindgen run every time as the case where CodegenRust.py changes but doesn't change the output.rsseems like it should be rare.r? @jdm