Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAutogenerate list of prototypes and code to register DOM bindings #577
Conversation
|
This is on top of #573, so only the last commit is new. |
| @@ -429,17 +429,19 @@ def resolve(self, parentScope): | |||
| pass | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| } | ||
|
|
||
| impl MouseEvent { | ||
| pub fn new(type_: DOMString, can_bubble: bool, cancelable: bool, |
This comment has been minimized.
This comment has been minimized.
pcwalton
Jul 11, 2013
Contributor
nit, usually I line these up under the (, and I'm not a big fan of type_ (prefer ty), but I won't block the review on this.
…n goop.
This comment has been minimized.
This comment has been minimized.
|
r=metajack |
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm, metajack |
This comment has been minimized.
This comment has been minimized.
|
merging jdm/servo/autogen = 4f24ef1 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm, metajack |
This comment has been minimized.
This comment has been minimized.
|
merging jdm/servo/autogen = 4f24ef1 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 821192d |
bors-servo
merged commit 4f24ef1
into
servo:master
1 check passed
1 check passed
default
all tests passed
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Fix replay crash on startup <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/577) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJul 11, 2013
No description provided.