Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBeginnings of iframe handling and navigation bug fix #580
Conversation
This comment has been minimized.
This comment has been minimized.
metajack
commented on c323585
Jul 12, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging tkuehn/servo/master = c323585 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 1187311 |
bors-servo
merged commit c323585
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
remove unused directory per web-platform-tests/wpt#105
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
reuse alloc_image() to get the image_key in RenderApi::add_image() This is a trivial update. WR already has a function to create a image_key obj[1]. RenderApi::add_image() should use that. [1] https://github.com/JerryShih/webrender/blob/c3d675d5307c2d34d00cfae67c24228f894678d9/webrender_traits/src/api.rs#L84 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/580) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tikue commentedJul 11, 2013
Fixes #579.