Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple document load tracking infrastructure #5804

Merged
merged 4 commits into from May 11, 2015
Merged

Conversation

@jdm
Copy link
Member

jdm commented Apr 23, 2015

This implements a simple load-tracking system and tracks stylesheet loads as an example of how it fits together. This is a simplified and rebased version of #3714; I do not believe that the main thrust of hsivonen's comments (related to tracking navigation in browsing contexts) affect this part of the work.

r? @Ms2ger

Review on Reviewable

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 23, 2015

Rebase before critic picks it up?

@jdm jdm force-pushed the jdm:docloader branch from 889c804 to 2198a93 Apr 23, 2015
@jdm
Copy link
Member Author

jdm commented Apr 23, 2015

Done.

@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2015

The latest upstream changes (presumably #5808) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm jdm force-pushed the jdm:docloader branch from 668f228 to dc1db4d Apr 30, 2015
@jdm
Copy link
Member Author

jdm commented Apr 30, 2015

@Ms2ger Rebased.

@Ms2ger Ms2ger closed this Apr 30, 2015
@Ms2ger Ms2ger reopened this Apr 30, 2015
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 30, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4865

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2015

The latest upstream changes (presumably #5912) made this pull request unmergeable. Please resolve the merge conflicts.

jdm added 3 commits Oct 13, 2014
…s the script task when the queue is empty. Dispatch the document load event based on the DocumentLoader's notification.
@jdm jdm force-pushed the jdm:docloader branch from 4a22d02 to 1de2c29 May 11, 2015
@jdm
Copy link
Member Author

jdm commented May 11, 2015

@bors-servo: r=Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2015

📌 Commit 1de2c29 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2015

Testing commit 1de2c29 with merge dfef2ef...

bors-servo pushed a commit that referenced this pull request May 11, 2015
This implements a simple load-tracking system and tracks stylesheet loads as an example of how it fits together. This is a simplified and rebased version of #3714; I do not believe that the main thrust of hsivonen's comments (related to tracking navigation in browsing contexts) affect this part of the work. 

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5804)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2015

💔 Test failed - mac1

@jdm jdm force-pushed the jdm:docloader branch from 1de2c29 to a1ae53a May 11, 2015
@jdm
Copy link
Member Author

jdm commented May 11, 2015

@bors-servo: r=Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2015

📌 Commit a1ae53a has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2015

Testing commit a1ae53a with merge 2baa695...

bors-servo pushed a commit that referenced this pull request May 11, 2015
bors-servo
This implements a simple load-tracking system and tracks stylesheet loads as an example of how it fits together. This is a simplified and rebased version of #3714; I do not believe that the main thrust of hsivonen's comments (related to tracking navigation in browsing contexts) affect this part of the work. 

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5804)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 11, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit a1ae53a into servo:master May 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm deleted the jdm:docloader branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.