Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFloats more complete #585
Merged
Floats more complete #585
Conversation
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/main/layout/block.rs in 602334a
Jul 12, 2013
|
Looks like you added extra space here. |
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/main/layout/float_context.rs in a6f6ce9
Jul 12, 2013
|
Does this need to be always? Perhaps #[inline] is enough? |
This comment has been minimized.
This comment has been minimized.
metajack
commented on src/components/main/layout/float_context.rs in a6f6ce9
Jul 12, 2013
|
This probably should be #[inline] |
This comment has been minimized.
This comment has been minimized.
metajack
commented on f68a548
Jul 12, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging eric93/servo/floats-2 = f68a548 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 9099892 |
bors-servo
pushed a commit
that referenced
this pull request
Jul 12, 2013
Everything except for floats in an inline formatting context and clear.
bors-servo
merged commit f68a548
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Add Wrench to WebRender This moves Wrench to WebRender. It can now replay binary recordings (replaces the wr-replay tool, though I haven't removed that one), show frames from YAML, and write YAML while replaying a binary recording. The YAML stuff is very much WIP, but what's there works and can be built on top of. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/585) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eric93 commentedJul 12, 2013
Everything except for floats in an inline formatting context and clear.