Implement the HTML background attribute

[evilpie]

Fixes #5835

[highfive]

Warning

• These commits modify unsafe code. Please review it carefully!

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/4805

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[evilpie]

I doubt you will merge it like that. get_background should probably be moved from HTMLBodyElementHelpers to something that is layout specific. If there was some way to get the document base inside legacy.rs everything would be a lot easier.

[SimonSapin]

^{components/script/dom/htmlbodyelement.rs, line 86 [r1] (raw file):}
Can this .clone() be avoided? Maybe the method would have to return std::cell::Ref<Option<Url>>.

---

^{components/script/dom/htmlbodyelement.rs, line 135 [r1] (raw file):}
Use .ok() to get an Option from a Result.

---

---

Comments from the review on Reviewable.io

[bors-servo]

☔ The latest upstream changes (presumably #5857) made this pull request unmergeable. Please resolve the merge conflicts.

[SimonSapin]

@Ms2ger, what do you think is the right way to access an element’s base URL from legacy.rs?

[Ms2ger]

There shouldn't be anything in legacy.rs. We don't support base, so I guess document_from_node(element).url() or something like that.

[waddlesplash]

@evilpie Any update on this? If you're unable to continue, I might be able to spare some time to complete it...

[evilpie]

I am going to continue working on this soon.

[SimonSapin]

There shouldn't be anything in legacy.rs.

If I understand correctly, you mean that this should use the new infrastructure for presentational hints where the work happens in components/script/dom/element.rs rather than in legacy.rs, as in #5988. Is that right?

[SimonSapin]

@Ms2ger ↑

[evilpie]

Sorry, I am not quite sure how to use Ref<>.

[bors-servo]

☔ The latest upstream changes (presumably #6150) made this pull request unmergeable. Please resolve the merge conflicts.

[evilpie]

I rebased this again. I still not sure how to use Ref<>.

[metajack]

@SimonSapin ping

[SimonSapin]

@bors-servo r+

---

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

^{components/script/dom/htmlbodyelement.rs, line 102 [r1] (raw file):}
On further reading, this is used to create a BackgroundImage which wants to own an Url anyway, so removing the clone here would only move it.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit d3f92eb has been approved by SimonSapin

[bors-servo]

⌛ Testing commit d3f92eb with merge 58fa3b6...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3