Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor WebGL implementation (reopens #5769) #5863
Conversation
highfive
commented
Apr 27, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. |
highfive
commented
Apr 27, 2015
|
|
hoppipolla-critic-bot
commented
Apr 27, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4812 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Still needs a rebase, unfortunately. |
|
Yep, I was just doing it. The previous issue was that I failed to merge some old commits when the first implementation wasn't in master yet. Should be mergeable now, sorry. |
|
@bors-servo: r+ |
|
|
GitHub doesn't allow me to reopen #5769, so I created this. Sorry about the merge fail, my bad :/ cc/ @jdm @dmarcos --- This PR uses customized GL context creation code, right now only working under Linux, so I expect the clearcolor test to fail on other platforms. It addresses some other problems: * Propagates context creation error to the top, returning null if not found. * Uses GLContextAttributes, which will allow us to write WebGLContextAttributes easily. * Doesn't allow a 2d context and a WebGL context coexist. * Panics when resizing the context to larger dimensions (to be fixed soon, but better than blindly allowing it). Removes some unused dependencies <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5863) <!-- Reviewable:end -->
|
|
|
Rewinded to old cocoa version. I kept winapi version since it was duplicated in master. |
|
@bors-servo: r+ |
|
|
GitHub doesn't allow me to reopen #5769, so I created this. Sorry about the merge fail, my bad :/ cc/ @jdm @dmarcos --- This PR uses customized GL context creation code, right now only working under Linux, so I expect the clearcolor test to fail on other platforms. It addresses some other problems: * Propagates context creation error to the top, returning null if not found. * Uses GLContextAttributes, which will allow us to write WebGLContextAttributes easily. * Doesn't allow a 2d context and a WebGL context coexist. * Panics when resizing the context to larger dimensions (to be fixed soon, but better than blindly allowing it). Removes some unused dependencies <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5863) <!-- Reviewable:end -->
emilio commentedApr 27, 2015
GitHub doesn't allow me to reopen #5769, so I created this.
Sorry about the merge fail, my bad :/
cc/ @jdm @dmarcos
This PR uses customized GL context creation code, right now only working under Linux, so I expect the clearcolor test to fail on other platforms.
It addresses some other problems:
Removes some unused dependencies