Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Body.bgColor and Document.bgColor #5868

Merged
merged 2 commits into from Apr 27, 2015
Merged

Implement Body.bgColor and Document.bgColor #5868

merged 2 commits into from Apr 27, 2015

Conversation

@nox
Copy link
Member

nox commented Apr 27, 2015

Review on Reviewable
@nox
Complete Document WebIDL interface
34070b1
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 27, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4816

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@nox
Copy link
Member Author

nox commented Apr 27, 2015

s/background/bgColor/ once it's reviewed.
@nox nox changed the title Implement Body.background and Document.background Implement Body.bgcolor and Document.bgcolor Apr 27, 2015
@jdm
Copy link
Member

jdm commented Apr 27, 2015

Reviewed files:

  • components/script/dom/document.rs @ r2
  • components/script/dom/htmlbodyelement.rs @ r2
  • components/script/dom/webidls/Document.webidl @ r2
  • components/script/dom/webidls/HTMLBodyElement.webidl @ r2
  • tests/wpt/metadata/html/dom/interfaces.html.ini @ r2
  • tests/wpt/metadata/html/dom/reflection-sections.html.ini @ r2
  • tests/wpt/metadata/html/obsolete/requirements-for-implementations/other-elements-attributes-and-apis/document-color-02.html.ini @ r2
  • tests/wpt/metadata/html/obsolete/requirements-for-implementations/other-elements-attributes-and-apis/document-color-03.html.ini @ r2
  • tests/wpt/metadata/html/obsolete/requirements-for-implementations/other-elements-attributes-and-apis/document-color-04.html.ini @ r2

Comments from the review on Reviewable.io
@nox
Implement Body.bgColor and Document.bgColor
Loading status checks…
1697362
@nox nox force-pushed the nox:document-legacy branch from 21f97e2 to 1697362 Apr 27, 2015
@nox nox changed the title Implement Body.bgcolor and Document.bgcolor Implement Body.bgColor and Document.bgColor Apr 27, 2015
@jdm
Copy link
Member

jdm commented Apr 27, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2015

📌 Commit 1697362 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2015

⌛ Testing commit 1697362 with merge 1cdd942...
bors-servo pushed a commit that referenced this pull request Apr 27, 2015
bors-servo
Auto merge of #5868 - nox:document-legacy, r=jdm
1cdd942 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5868)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2015

💔 Test failed - linux2
@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 27, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2015

⌛ Testing commit 1697362 with merge 9ec2ce0...
bors-servo pushed a commit that referenced this pull request Apr 27, 2015
bors-servo
Auto merge of #5868 - nox:document-legacy, r=jdm
Loading status checks…
9ec2ce0 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5868)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 1697362 into servo:master Apr 27, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:document-legacy branch Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @hoppipolla-critic-bot @jdm @bors-servo @Ms2ger @highfive
You can’t perform that action at this time.