Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor display lists to use an explicit traversal #589
Conversation
|
|
||
| /// Like traverse_preorder, but don't end the whole traversal if the callback | ||
| /// returns false. | ||
| fn partially_traverse_preorder(&self, callback: &fn(FlowContext) -> bool) { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eric93
Jul 16, 2013
Author
This function doesn't follow the iterator convention, since when the closure returns false it doesn't end the traversal.
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on 5fc794f
Jul 16, 2013
|
r+ Net loss of lines of code, nice! |
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging eric93/servo/diplaylist-refactor = 5fc794f into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 45e6873 |
bors-servo
merged commit 5fc794f
into
servo:master
1 check passed
1 check passed
default
all tests passed
This comment has been minimized.
This comment has been minimized.
|
Is this supposed to use the new partial traverse? |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
…dershadowroot Removed tests using an obsolete attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eric93 commentedJul 16, 2013
No description provided.