Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix length value of interface methods #5902

Merged
merged 1 commit into from May 14, 2015
Merged

Fix length value of interface methods #5902

merged 1 commit into from May 14, 2015

Conversation

@nox
Copy link
Member

nox commented Apr 30, 2015

Blocked by w3c/testharness.js#124.

Review on Reviewable
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 30, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4861

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@nox nox mentioned this pull request Apr 30, 2015
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2015

☔ The latest upstream changes (presumably #5839) made this pull request unmergeable. Please resolve the merge conflicts.
@nox nox force-pushed the nox:length branch from a1e6bfa to a90797f Apr 30, 2015
@jdm
Copy link
Member

jdm commented Apr 30, 2015

-S-awaiting-review

Reviewed files:

  • components/script/dom/bindings/codegen/CodegenRust.py @ r1
  • tests/wpt/metadata/dom/interfaces.html.ini @ r1
  • tests/wpt/metadata/encoding/idlharness.html.ini @ r1
  • tests/wpt/metadata/FileAPI/idlharness.html.ini @ r1
  • tests/wpt/metadata/html/dom/interfaces.html.ini @ r1
  • tests/wpt/metadata/workers/interfaces.worker.js.ini @ r1
  • tests/wpt/metadata/XMLHttpRequest/interfaces.html.ini @ r1

Comments from the review on Reviewable.io
@jdm jdm removed the S-awaiting-review label Apr 30, 2015
@jdm
Copy link
Member

jdm commented May 6, 2015

-S-awaiting-review

Reviewed files:

  • tests/wpt/metadata/html/dom/interfaces.html.ini @ r2
  • tests/wpt/metadata/XMLHttpRequest/interfaces.html.ini @ r2

Comments from the review on Reviewable.io
@jdm jdm removed the S-awaiting-review label May 6, 2015
@jdm
Copy link
Member

jdm commented May 12, 2015

-S-awaiting-review +S-needs-squash

Reviewed files:

  • components/script/dom/bindings/codegen/CodegenRust.py @ r3

Comments from the review on Reviewable.io
@nox nox mentioned this pull request May 14, 2015
Merged
@nox nox force-pushed the nox:length branch from af44961 to de49657 May 14, 2015
@nox
Copy link
Member Author

nox commented May 14, 2015

@jdm Squashed.
@jdm
Copy link
Member

jdm commented May 14, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2015

📌 Commit de49657 has been approved by jdm
@jdm
Copy link
Member

jdm commented May 14, 2015

@bors-servo: r-
@jdm
Copy link
Member

jdm commented May 14, 2015

Sorry, forgot the WPT update hasn't happened yet.
@nox
Copy link
Member Author

nox commented May 14, 2015

@jdm I think it just did.
@nox
Copy link
Member Author

nox commented May 14, 2015

Oh wait, it's all grey.
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2015

☔ The latest upstream changes (presumably #6038) made this pull request unmergeable. Please resolve the merge conflicts.
@nox
Fix length value of interface methods
Loading status checks…
d961985
@nox nox force-pushed the nox:length branch from de49657 to d961985 May 14, 2015
@Ms2ger
Copy link
Contributor

Ms2ger commented May 14, 2015

@bors-servo: r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2015

📌 Commit d961985 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2015

⌛ Testing commit d961985 with merge 8faa9f8...
bors-servo pushed a commit that referenced this pull request May 14, 2015
bors-servo
Auto merge of #5902 - nox:length, r=jdm
Loading status checks…
8faa9f8 
Blocked by w3c/testharness.js#124.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5902)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 14, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit d961985 into servo:master May 14, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:length branch Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-review S-blocked-on-external
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @hoppipolla-critic-bot @bors-servo @jdm @Ms2ger @highfive
You can’t perform that action at this time.