Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for the rustup. #5916

Merged
merged 12 commits into from May 1, 2015
Merged

Prepare for the rustup. #5916

merged 12 commits into from May 1, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented May 1, 2015

Review on Reviewable
Ms2ger added 12 commits May 1, 2015
@Ms2ger
Stop using IndexMut on HashMap.
c95fc0c 
This feature was removed in rust-lang/rust#23559.
@Ms2ger
Remove a range() call.
ad4996b
@Ms2ger
Remove an as_slice() call.
0a5ffc4
@Ms2ger
Replace ByteString::as_slice() by a Deref implementation.
84b1b52
@Ms2ger
Add a Reflectable bound to Root's type parameter.
b59f54c
@Ms2ger
Add a Reflectable bound to Trusted's type parameter.
5f6b791
@Ms2ger
Use AsciiExt in ByteString implementations.
bd77acf
@Ms2ger
Replace -1 by !0 for unsigned integers.
568b7f3
@Ms2ger
Add a VecRootableType bound to RootedVec's type parameter.
9a97a7e
@Ms2ger
Stop using MemWriter in Element::serialize.
a3adf6a
@Ms2ger
Simplify the implementation of make_url_or_base_getter.
e282b71
@Ms2ger
Use a better name in TextEncoder::Encode.
Loading status checks…
99d6f83
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 1, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4877

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm
Copy link
Member

jdm commented May 1, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2015

📌 Commit 99d6f83 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2015

⌛ Testing commit 99d6f83 with merge 2f0b805...
bors-servo pushed a commit that referenced this pull request May 1, 2015
bors-servo
Auto merge of #5916 - servo:prepare-rustup, r=jdm
Loading status checks…
2f0b805 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5916)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2015

💔 Test failed - linux2
@jdm
Copy link
Member

jdm commented May 1, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2015

⚡ Previous build results for android, gonk, linux1, mac1, mac2 are reusable. Rebuilding only linux2...
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo mentioned this pull request May 1, 2015
Merged
@bors-servo bors-servo merged commit 99d6f83 into master May 1, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the prepare-rustup branch May 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @hoppipolla-critic-bot @jdm @bors-servo @highfive
You can’t perform that action at this time.