Partially implement getter of Document

[nox]

[nox]

Blocked by web-platform-tests/wpt#1801.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/4881

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[nox]

The two commits "make id attribute use an atom" should be "make name attribute use an atom", will reword once reviewed.

[jdm]

Why is the last commit removing WPT test files?

[nox]

Because I'm stupid and fail at git-rm'ing.

[nox]

@jdm I restored the tests and removed the expected results as they now pass (with my WPT PR).

[bors-servo]

☔ The latest upstream changes (presumably #5935) made this pull request unmergeable. Please resolve the merge conflicts.

[jdm]

-S-awaiting-review +S-needs-code-changes

---

Reviewed files:

• components/script/dom/document.rs @ r5
• components/script/dom/htmlappletelement.rs @ r2
• components/script/dom/htmlbodyelement.rs @ r1
• components/script/dom/htmlbuttonelement.rs @ r1
• components/script/dom/htmldialogelement.rs @ r1
• components/script/dom/htmlfieldsetelement.rs @ r1
• components/script/dom/htmlformelement.rs @ r4
• components/script/dom/htmlimageelement.rs @ r3
• components/script/dom/htmlmetaelement.rs @ r1
• components/script/dom/htmlobjectelement.rs @ r1
• components/script/dom/htmloptgroupelement.rs @ r1
• components/script/dom/htmloptionelement.rs @ r1
• components/script/dom/htmlselectelement.rs @ r1
• components/script/dom/macros.rs @ r1, r2
• components/script/dom/virtualmethods.rs @ r2, r4
• components/script/dom/webidls/Document.webidl @ r5
• components/script/dom/webidls/HTMLAppletElement.webidl @ r2
• tests/wpt/metadata/html/dom/documents/dom-tree-accessors/nameditem-01.html.ini @ r5
• tests/wpt/metadata/html/dom/documents/dom-tree-accessors/nameditem-03.html.ini @ r5
• tests/wpt/metadata/html/dom/documents/dom-tree-accessors/nameditem-04.html.ini @ r5
• tests/wpt/metadata/html/dom/documents/dom-tree-accessors/nameditem-06.html.ini @ r5
• tests/wpt/metadata/html/dom/interfaces.html.ini @ r2
• tests/wpt/metadata/html/dom/reflection-obsolete.html.ini @ r2

---

^{components/script/dom/document.rs, line 93 [r5] (raw file):}
nit: std::sync comes after std::ptr

---

^{components/script/dom/document.rs, line 1607 [r5] (raw file):}
Why this block?

---

^{components/script/dom/webidls/Document.webidl, line 84 [r5] (raw file):}
nit: leave the extra space after the //

---

^{components/script/dom/webidls/HTMLAppletElement.webidl, line 15 [r2] (raw file):}
nit: it's preferable to leave the spacing as-is and just remove the //.

---

Comments from the review on Reviewable.io

[nox]

^{components/script/dom/document.rs, line 1607 [r5] (raw file):}
Because elements borrows name.

---

Comments from the review on Reviewable.io

[jdm]

-S-needs-code-changes +S-needs-squash

---

Comments from the review on Reviewable.io

[jdm]

@bors-servo: r+

[bors-servo]

📌 Commit 1c8c0ca has been approved by jdm

[bors-servo]

⌛ Testing commit 1c8c0ca with merge d23d077...

[bors-servo]

💔 Test failed - mac1

[jdm]

/html/dom/documents/dom-tree-accessors/nameditem-06.html
--------------------------------------------------------
FAIL If there are two imgs, nothing should be returned. (id)

[nox]

@jdm It needs web-platform-tests/wpt#1801, was WPT updated?

[jdm]

Whoops; not yet.

[bors-servo]

☔ The latest upstream changes (presumably #5800) made this pull request unmergeable. Please resolve the merge conflicts.

[Ms2ger]

@bors-servo: r=jdm

[bors-servo]

📌 Commit 0e8bd5d has been approved by jdm

[bors-servo]

⌛ Testing commit 0e8bd5d with merge a635a8f...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2