Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compositor to use messages rather than callbacks #593

Closed
wants to merge 1 commit into from

Conversation

@eschweic
Copy link

eschweic commented Jul 17, 2013

Replaces #520 so we don't have to go through the pain of rebasing it.
r? @pcwalton

let done = @mut false;
let recomposite = @mut false;
let mut scene = ~Scene(ContainerLayerKind(root_layer), window_size, identity());
let mut done = ~false;

This comment has been minimized.

@pcwalton

pcwalton Jul 17, 2013

Contributor

These don't need to be heap allocated, do they?

@metajack

This comment has been minimized.

Copy link

metajack commented on d695b2d Jul 18, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on d695b2d Jul 18, 2013

saw approval from metajack
at eschweic@d695b2d

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 18, 2013

merging eschweic/servo/windowing-messages = d695b2d into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 18, 2013

eschweic/servo/windowing-messages = d695b2d merged ok, testing candidate = 09acdcc

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 18, 2013

fast-forwarding master to auto = 09acdcc

bors-servo pushed a commit that referenced this pull request Jul 18, 2013
Replaces #520 so we don't have to go through the pain of rebasing it.
r? @pcwalton
@bors-servo bors-servo closed this Jul 18, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
…styles-test

Adjusted queryselector to operate on the SR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.