Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove helpers that correspond to DOM methods #5931

Merged
merged 1 commit into from May 6, 2015
Merged

Remove helpers that correspond to DOM methods #5931

merged 1 commit into from May 6, 2015

Conversation

@nox
Copy link
Member

nox commented May 4, 2015

Review on Reviewable
@nox
Remove helpers that correspond to DOM methods
Loading status checks…
06436e9
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 4, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4889

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@nox
Copy link
Member Author

nox commented May 4, 2015

This remove parent_node(), first_child(), last_child(), prev_sibling() and next_sibling() from both NodeHelpers and TreeWalkerHelpers and prev_node() and next_node() from the latter.
@jdm
Copy link
Member

jdm commented May 6, 2015

@bors-servo: r+
-S-awaiting-review +S-awaiting-merge

Reviewed files:

  • components/script/dom/document.rs @ r1
  • components/script/dom/element.rs @ r1
  • components/script/dom/htmloptionelement.rs @ r1
  • components/script/dom/node.rs @ r1
  • components/script/dom/range.rs @ r1
  • components/script/dom/text.rs @ r1
  • components/script/dom/treewalker.rs @ r1
  • components/script/parse/html.rs @ r1

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

📌 Commit 06436e9 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

⌛ Testing commit 06436e9 with merge 16a7c79...
bors-servo pushed a commit that referenced this pull request May 6, 2015
bors-servo
Auto merge of #5931 - nox:rm-helpers, r=jdm
Loading status checks…
16a7c79 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5931)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

💔 Test failed - mac2
@jdm
Copy link
Member

jdm commented May 6, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

⚡ Previous build results for android, gonk, linux1, linux2, mac1 are reusable. Rebuilding only mac2...
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 06436e9 into servo:master May 6, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:rm-helpers branch Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @hoppipolla-critic-bot @jdm @bors-servo @highfive
You can’t perform that action at this time.