Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for building without --release #5941

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -149,6 +149,10 @@ def build(self, target=None, release=False, jobs=None, android=None,
# Generate Desktop Notification if elapsed-time > some threshold value
notify(elapsed)

# Print warning if release flag is not used
if release is False:
print("[Warning] This is an un-optimized debug build. For performance testing, use ./mach build --release to enable compiler optimizations.")

print("Build completed in %0.2fs" % elapsed)
return status

@@ -252,7 +256,7 @@ def build_tests(self, jobs=None):
@CommandArgument('--verbose', '-v',
action='store_true',
help='Print verbose output')

@CommandArgument('params', nargs='...',
help="Command-line arguments to be passed through to Cargo")
def clean(self, manifest_path, params, verbose=False):
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.