Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSuggest how to fix unstable WHATWG links in tidy.py #5942
Merged
Conversation
hoppipolla-critic-bot
commented
May 5, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4902 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@bors-servo: r+ |
|
|
|
Looks great; thanks! |
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 6, 2015
Simplified the checking logic a bit too; only a single match per line and a stricter regex that matches everything in one go. I tested this against commit 8b08c6f and made sure it caught the same problems. Note that tidy doesn't currently check the webidls, so those would have still made it through. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5942) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 6, 2015
Simplified the checking logic a bit too; only a single match per line and a stricter regex that matches everything in one go. I tested this against commit 8b08c6f and made sure it caught the same problems. Note that tidy doesn't currently check the webidls, so those would have still made it through. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5942) <!-- Reviewable:end -->
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ghost commentedMay 5, 2015
Simplified the checking logic a bit too; only a single match per line and a stricter regex that matches everything in one go.
I tested this against commit 8b08c6f and made sure it caught the same problems. Note that tidy doesn't currently check the webidls, so those would have still made it through.