Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas: implement transformation matrix reset. #5946

Merged
merged 1 commit into from May 6, 2015
Merged

Canvas: implement transformation matrix reset. #5946

merged 1 commit into from May 6, 2015

Conversation

@mmatyas
Copy link
Contributor

mmatyas commented May 5, 2015

Review on Reviewable
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 5, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4907

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm jdm added the S-fails-tidy label May 5, 2015
@mmatyas mmatyas force-pushed the mmatyas:canvas_mxreset branch from be0f9a7 to 856220a May 5, 2015
@jdm
Copy link
Member

jdm commented May 6, 2015

-S-awaiting-review +S-needs-code-changes

Be sure to address the output of ./mach test-tidy as well!

Reviewed files:

  • components/script/dom/canvasrenderingcontext2d.rs @ r1
  • components/script/dom/webidls/CanvasRenderingContext2D.webidl @ r1
  • tests/ref/2dcontext/reset_transform_a.html @ r1
  • tests/ref/2dcontext/reset_transform_ref.html @ r1
  • tests/ref/basic.list @ r1

tests/ref/basic.list, line 14 [r1] (raw file):
Let's create a WPT reftest instead, since we're progressively moving all of ours to it. See #5925 .

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

☔ The latest upstream changes (presumably #5961) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member

jdm commented May 6, 2015

-S-awaiting-review +S-needs-rebase -S-fails-tidy +S-needs-squash

Reviewed files:

  • tests/ref/2dcontext/reset_transform_a.html @ r2
  • tests/ref/2dcontext/reset_transform_ref.html @ r2
  • tests/ref/basic.list @ r2
  • tests/wpt/metadata/html/dom/interfaces.html.ini @ r2
  • tests/wpt/metadata/MANIFEST.json @ r2
  • tests/wpt/web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001-ref.html @ r2
  • tests/wpt/web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001.html @ r2

Comments from the review on Reviewable.io
@mmatyas
Canvas: implement transformation matrix reset.
Loading status checks…
9302aaa
@mmatyas mmatyas force-pushed the mmatyas:canvas_mxreset branch from 7771a05 to 9302aaa May 6, 2015
@mmatyas
Copy link
Contributor Author

mmatyas commented May 6, 2015

Rebased and squashed.
@jdm
Copy link
Member

jdm commented May 6, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

📌 Commit 9302aaa has been approved by jdm
bors-servo pushed a commit that referenced this pull request May 6, 2015
bors-servo
Auto merge of #5946 - mmatyas:canvas_mxreset, r=jdm
4c8d2a5 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5946)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

⌛ Testing commit 9302aaa with merge 4c8d2a5...
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

💔 Test failed - linux2
@jdm
Copy link
Member

jdm commented May 6, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

⌛ Testing commit 9302aaa with merge d9cc36a...
bors-servo pushed a commit that referenced this pull request May 6, 2015
bors-servo
Auto merge of #5946 - mmatyas:canvas_mxreset, r=jdm
Loading status checks…
d9cc36a 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5946)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 9302aaa into servo:master May 6, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mmatyas mmatyas deleted the mmatyas:canvas_mxreset branch Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mmatyas @hoppipolla-critic-bot @jdm @bors-servo @highfive
You can’t perform that action at this time.