Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExtend the developer tools support #5947
Merged
Conversation
hoppipolla-critic-bot
commented
May 5, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4908 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
Add a NetworkEventActor to devtools/actors/ Authors: Ashritha Mohan Ram <amohanr@ncsu.edu> Himaja Valavala <hsvalava@ncsu.edu> Anand Chandrasekar <achandr9@ncsu.edu> Yiyang Wang <ywang95@ncsu.edu>
… and HttpResponse messages 2. Change run_server to handle network events 3. Add a unique id to track request-actor associations 4. Update the network event actor
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 5, 2015
Implement HTTP request/response notifications per https://github.com/servo/servo/wiki/More-developer-tools-student-project . Rebased from #5920. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5947) <!-- Reviewable:end -->
|
|
…responding parameter to LoadData::new() 2. Change addEvent in the NetworkEventActor to add_request and add_response
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 5, 2015
Implement HTTP request/response notifications per https://github.com/servo/servo/wiki/More-developer-tools-student-project . Rebased from #5920. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5947) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMay 5, 2015
Implement HTTP request/response notifications per https://github.com/servo/servo/wiki/More-developer-tools-student-project .
Rebased from #5920.