Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove Glutin dependency for WebGL #5957
Conversation
highfive
commented
May 6, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon. |
hoppipolla-critic-bot
commented
May 6, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4919 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
-S-awaiting-review +S-needs-code-changes Reviewed files:
components/canvas/webgl_paint_task.rs, line 208 [r1] (raw file): Comments from the review on Reviewable.io |
|
components/canvas/webgl_paint_task.rs, line 208 [r1] (raw file): Comments from the review on Reviewable.io |
|
@bors-servo: r+ Comments from the review on Reviewable.io |
|
|
Now we have mac support, and since android build is broken, we can drop glutin from WebGL code. Went back to upstream repo, see: servo/surfman#1 (comment) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5957) <!-- Reviewable:end -->
|
|
This needs a update-cargo. |
|
|
Now we have mac support, and since android build is broken, we can drop glutin from WebGL code. Went back to upstream (see: servo/surfman#1 (comment)) Rebased
|
@bors-servo: r+ |
|
|
|
|
Now we have mac support, and since android build is broken, we can drop glutin from WebGL code. Went back to upstream repo, see: servo/surfman#1 (comment) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5957) <!-- Reviewable:end -->
emilio commentedMay 6, 2015
Now we have mac support, and since android build is broken, we can
drop glutin from WebGL code.
Went back to upstream repo, see:
servo/surfman#1 (comment)