Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CloseEvent. #5961

Merged
merged 4 commits into from May 6, 2015
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Make the CloseEvent members immutable.

  • Loading branch information
Ms2ger committed May 6, 2015
commit 692fc0904149ec8dfaa39b720b06c4a766aed86a
@@ -2,7 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

use dom::bindings::cell::DOMRefCell;
use dom::bindings::codegen::Bindings::EventBinding::EventMethods;
use dom::bindings::codegen::Bindings::CloseEventBinding;
use dom::bindings::codegen::Bindings::CloseEventBinding::CloseEventMethods;
@@ -17,23 +16,23 @@ use script_task::ScriptChan;
use util::str::DOMString;

use std::borrow::ToOwned;
use std::cell::Cell;

#[dom_struct]
pub struct CloseEvent {
event: Event,
wasClean: Cell<bool>,
code: Cell<u16>,
reason: DOMRefCell<DOMString>
wasClean: bool,
code: u16,
reason: DOMString,
}

impl CloseEvent {
pub fn new_inherited(type_id: EventTypeId) -> CloseEvent {
pub fn new_inherited(type_id: EventTypeId, wasClean: bool, code: u16,
reason: DOMString) -> CloseEvent {
CloseEvent {
event: Event::new_inherited(type_id),
wasClean: Cell::new(true),
code: Cell::new(0),
reason: DOMRefCell::new("".to_owned())
wasClean: wasClean,
code: code,
reason: reason,
}
}

@@ -44,19 +43,14 @@ impl CloseEvent {
wasClean: bool,
code: u16,
reason: DOMString) -> Temporary<CloseEvent> {
let ev = reflect_dom_object(box CloseEvent::new_inherited(EventTypeId::CloseEvent),
global,
CloseEventBinding::Wrap);
let ev = ev.root();
let event = box CloseEvent::new_inherited(EventTypeId::CloseEvent,
wasClean, code, reason);
let ev = reflect_dom_object(event, global, CloseEventBinding::Wrap).root();
let event: JSRef<Event> = EventCast::from_ref(ev.r());
event.InitEvent(type_,
bubbles == EventBubbles::Bubbles,
cancelable == EventCancelable::Cancelable);
let ev = ev.r();
ev.wasClean.set(wasClean);
ev.code.set(code);
*ev.reason.borrow_mut() = reason;
Temporary::from_rooted(ev)
Temporary::from_rooted(ev.r())
}

pub fn Constructor(global: GlobalRef,
@@ -77,15 +71,14 @@ impl CloseEvent {

impl<'a> CloseEventMethods for JSRef<'a, CloseEvent> {
fn WasClean(self) -> bool {
self.wasClean.get()
self.wasClean
}

fn Code(self) -> u16 {
self.code.get()
self.code
}

fn Reason(self) -> DOMString {
let reason = self.reason.borrow();
reason.clone()
self.reason.clone()
}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.